test: echo file contents in e2e test if a file contents check fails. #7656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmy-wright
requested review from
AbelHu,
Devinwong,
awesomenix,
cameronmeissner,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
phealy,
r2k1 and
zachary-bailey
as code owners
timmy-wright
changed the title
| s.T.Fatalf("expected file %s to have contents %q, but it does not", fileName, contents) | ||
| actualContents, err := getFileContent(ctx, s, fileName) | ||
| if err != nil { | ||
| s.T.Fatalf("expected file %s to have contents %q, but it does not. Could not determine actual contents due to %s", fileName, contents, err.Error()) |
Contributor
There was a problem hiding this comment.
I think this error should just read Could not determine actual contents due to %s since we don't actually know if the contents match or not in this case
| s.T.Fatalf("expected file %s to not have contents %q, but it does", fileName, contents) | ||
| actualContents, err := getFileContent(ctx, s, fileName) | ||
| if err != nil { | ||
| s.T.Fatalf("expected file %s to have contents %q, but it does. Could not determine actual contents due to %s", fileName, contents, err.Error()) |
djsly
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Makes debugging tests easier. We used to have the file contents in the test log when we logged the script execution. But that was removed because the logs were too large.
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: