feat: redirect mcr.azk8s.cn to mcr.azure.cn in Windows containerd #7646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiashun0011
requested review from
AbelHu,
Devinwong,
awesomenix,
cameronmeissner,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
jiashun0011
force-pushed
the
jiashunliu/mcr-migration-cse
branch
from
27d1029 to
e09841e
Compare
fseldow
reviewed
Jan 13, 2026
| func Test_Windows2022_McrChinaCloud_Windows(t *testing.T) { | ||
| RunScenario(t, &Scenario{ | ||
| Tags: Tags{ | ||
| MockAzureChinaCloud: true, |
Contributor
There was a problem hiding this comment.
can we try to change the e2e daemonset test image from mcr.microsoft.com to mcr.azk8s.cn if detect MockAzureChinaCloud=true
fseldow
reviewed
Jan 13, 2026
Contributor
|
incorrect title |
jiashun0011
changed the title
jiashun0011
force-pushed
the
jiashunliu/mcr-migration-cse
branch
from
e09841e to
feb7075
Compare
jiashun0011
force-pushed
the
jiashunliu/mcr-migration-cse
branch
from
feb7075 to
d7023fa
Compare
jiashun0011
force-pushed
the
jiashunliu/mcr-migration-cse
branch
from
d7023fa to
78cfbb8
Compare
jiashun0011
force-pushed
the
jiashunliu/mcr-migration-cse
branch
from
78cfbb8 to
9fe0470
Compare
Contributor
|
Minor comment on the release note:
What is actually done should be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fallback mcr.azk8s.cn to mcr.azure.cn in Windows containerd
Requirements:
Special notes for your reviewer:
Release note: