Skip to content

Conversation

@saewoni
Copy link

@saewoni saewoni commented Jan 12, 2026

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

  • uses conventional commit messages
  • includes documentation
  • adds unit tests
  • tested upgrade from previous version
  • commits are GPG signed and Github marks them as verified

Special notes for your reviewer:

Release note:

none

- Cache MCR IPs in /etc/hosts.testing, read by LocalDNS Corefile
- Run mcr-hosts-setup timer every 5min (was 30s) with 60s randomization
- Only enable when LocalDNS is active
- Improve error handling and regex validation
Wrapped the hosts /etc/hosts.testing section in isRootDomain conditional
so it only applies to .:53 VnetDNS queries, not cluster.local or custom
domains. Updated tests and regenerated testdata.
@github-actions
Copy link
Contributor

PR Title Lint Failed ❌

Current Title: Sakwa/localdns poc

Your PR title doesn't follow the expected format. Please update your PR title to follow one of these patterns:

Conventional Commits Format:

  • feat: add new feature - for new features
  • fix: resolve bug in component - for bug fixes
  • docs: update README - for documentation changes
  • refactor: improve code structure - for refactoring
  • test: add unit tests - for test additions
  • chore: remove dead code - for maintenance tasks
  • chore(deps): update dependencies - for updating dependencies
  • ci: update build pipeline - for CI/CD changes

Guidelines:

  • Use lowercase for the type and description
  • Keep the description concise but descriptive
  • Use imperative mood (e.g., "add" not "adds" or "added")
  • Don't end with a period

Examples:

  • feat(windows): add secure TLS bootstrapping for Windows nodes
  • fix: resolve kubelet certificate rotation issue
  • docs: update installation guide
  • Added new feature
  • Fix bug.
  • Update docs

Please update your PR title and the lint check will run again automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants