Skip to content

Conversation

@abossard
Copy link

@abossard abossard commented Feb 4, 2025

Purpose

When trying to process a WSDL with includes, if any include defines a xmlns:xsd attribute, it will fail with a key error, since dotnet XSL parser always adds an xmlns:xs attribute and the ToDictionary will have a key clash.

This PR will make it so that you can have multiple times the same namespace when doing includes. Which is correct, since the included namespace could use an existing namespace on a different property.

Enhancements to Namespace Handling:

Addition of New Schema and WSDL Files:

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
  • Test it on the new includeExample
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

@abossard abossard marked this pull request as ready for review February 4, 2025 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant