This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Get NPM scripts to work cross-platform#77
Open
brcrista wants to merge 1 commit intoAzure-Samples:masterfrom
Open
Get NPM scripts to work cross-platform#77brcrista wants to merge 1 commit intoAzure-Samples:masterfrom
brcrista wants to merge 1 commit intoAzure-Samples:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These scripts were broken on macOS / Linux:
In Windows CMD shells, single
&means "run A then B", like a semicolon.In Bash shells, single
&means "run A in the background."In both shells, double
&&means "run A then run B if A was successful." I believe this is what we want. Tested in PowerShell as well.A possibly better fix would be to move the
npm installstep to the Gulpfile so it doesn't have to be repeated every time, but this is the quicker fix in line with the current design.