Conversation
…tacking Restore button cell attributes (width, text-align, display) lost during the renderer class refactor, and add proper responsive stacking for mobile viewports. Includes targeting the implicit <tbody> element that was preventing width overrides from propagating. Also ensures consistent font-size on the "Powered by Jetpack Forms" link across email clients. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Bump field labels from 12px to 15px, field values from 13px to 16px, and choice chips (multi-select and consent) from 13px to 16px for improved readability. Updates both stylesheet and inline styles. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adjust icon cell top padding from 20px to 18px to visually center the 24px field icons with the adjacent label text. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
There was a problem hiding this comment.
Pull request overview
This PR fixes design issues in the Forms email notification template, addressing a button layout regression and implementing several visual improvements for better readability and mobile responsiveness.
Changes:
- Restores button layout attributes (
width="50%",text-align,display: inline-block) that were lost during a previous refactor - Adds comprehensive mobile-responsive CSS media queries to stack action buttons vertically on narrow viewports (< 640px)
- Increases font sizes for improved readability: field labels (12px → 15px), field values and chips (13px → 16px)
- Ensures consistent font sizing on the "Powered by Jetpack Forms" footer link by adding explicit inline styles
- Adjusts icon cell padding for better vertical alignment with label text
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| projects/packages/forms/src/contact-form/templates/email-response.php | Updates CSS font sizes for labels, values, and chips; adds mobile responsive media queries for button stacking |
| projects/packages/forms/src/contact-form/class-feedback-field.php | Updates inline font sizes for email chips and consent chips to match template CSS changes |
| projects/packages/forms/src/contact-form/class-feedback-email-renderer.php | Restores button cell layout attributes, adjusts icon alignment padding, updates label/value font sizes, and adds explicit font size to footer link |
| projects/packages/forms/changelog/fix-forms-email-template-design-feedback | Documents the changes with proper changelog entry following project conventions |
Code Coverage SummaryCoverage changed in 2 files.
Full summary · PHP report · JS report If appropriate, add one of these labels to override the failing coverage check:
Covered by non-unit tests
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Proposed changes:
width="50%",text-align, anddisplay: inline-blockattributes on button cells that were lost<table>,<tbody>,<tr>, and<td>elements (the implicit<tbody>was preventing width overrides from propagating)font-size: 13pxto the anchor tagOther information:
Does this pull request change what data or activity we track or use?
No.
Testing instructions: