Skip to content

Forms: Email template design feedback fixes#47127

Open
vianasw wants to merge 5 commits intotrunkfrom
fix/forms-email-template-design-feedback
Open

Forms: Email template design feedback fixes#47127
vianasw wants to merge 5 commits intotrunkfrom
fix/forms-email-template-design-feedback

Conversation

@vianasw
Copy link
Contributor

@vianasw vianasw commented Feb 13, 2026

Proposed changes:

  • Fix button layout regression introduced during the renderer class refactor — restores width="50%", text-align, and display: inline-block attributes on button cells that were lost
  • Add responsive mobile stacking for action buttons using media queries that properly target <table>, <tbody>, <tr>, and <td> elements (the implicit <tbody> was preventing width overrides from propagating)
  • Increase font sizes for improved readability: field labels 12px → 15px, field values 13px → 16px, choice chips 13px → 16px
  • Ensure consistent font-size on the "Powered by Jetpack Forms" link across email clients by adding explicit font-size: 13px to the anchor tag
  • Vertically align field icons with adjacent label text by adjusting icon cell padding

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • Set up a local Jetpack dev environment with a form that includes multiple field types (text, multi-select, consent, dropdown)
  • Submit the form and check the notification email
  • Button layout (desktop): Verify "Mark as spam" and "View in dashboard" buttons appear side-by-side, centered, with minimal gap between them
  • Button layout (mobile): View the email at a narrow viewport (< 640px) — buttons should stack vertically, full-width, and centered
  • Font sizes: Field labels should be 15px, field values and choice chips 16px — check they look proportional and readable
  • Powered by: "Powered by" and "Jetpack Forms" in the footer should appear the same font size
  • Icon alignment: Field icons (left of labels) should be vertically centered with the label text, not offset

vianasw and others added 4 commits February 13, 2026 17:40
…tacking

Restore button cell attributes (width, text-align, display) lost during
the renderer class refactor, and add proper responsive stacking for mobile
viewports. Includes targeting the implicit <tbody> element that was
preventing width overrides from propagating. Also ensures consistent
font-size on the "Powered by Jetpack Forms" link across email clients.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Bump field labels from 12px to 15px, field values from 13px to 16px,
and choice chips (multi-select and consent) from 13px to 16px for
improved readability. Updates both stylesheet and inline styles.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Adjust icon cell top padding from 20px to 18px to visually center
the 24px field icons with the adjacent label text.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings February 13, 2026 17:36
@vianasw vianasw added the [Status] Needs Review This PR is ready for review. label Feb 13, 2026
@vianasw vianasw self-assigned this Feb 13, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/forms-email-template-design-feedback branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/forms-email-template-design-feedback

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes design issues in the Forms email notification template, addressing a button layout regression and implementing several visual improvements for better readability and mobile responsiveness.

Changes:

  • Restores button layout attributes (width="50%", text-align, display: inline-block) that were lost during a previous refactor
  • Adds comprehensive mobile-responsive CSS media queries to stack action buttons vertically on narrow viewports (< 640px)
  • Increases font sizes for improved readability: field labels (12px → 15px), field values and chips (13px → 16px)
  • Ensures consistent font sizing on the "Powered by Jetpack Forms" footer link by adding explicit inline styles
  • Adjusts icon cell padding for better vertical alignment with label text

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
projects/packages/forms/src/contact-form/templates/email-response.php Updates CSS font sizes for labels, values, and chips; adds mobile responsive media queries for button stacking
projects/packages/forms/src/contact-form/class-feedback-field.php Updates inline font sizes for email chips and consent chips to match template CSS changes
projects/packages/forms/src/contact-form/class-feedback-email-renderer.php Restores button cell layout attributes, adjusts icon alignment padding, updates label/value font sizes, and adds explicit font size to footer link
projects/packages/forms/changelog/fix-forms-email-template-design-feedback Documents the changes with proper changelog entry following project conventions

@jp-launch-control
Copy link

jp-launch-control bot commented Feb 13, 2026

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/contact-form/templates/email-response.php 0/32 (0.00%) 0.00% 10 💔
projects/packages/forms/src/contact-form/class-feedback-email-renderer.php 119/300 (39.67%) -0.27% 2 ❤️‍🩹

Full summary · PHP report · JS report

If appropriate, add one of these labels to override the failing coverage check: Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Coverage tests to be added later Use to ignore the Code coverage requirement check when tests will be added in a follow-up PR I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant