Agents Manager: add support for disconnected variants#47088
Agents Manager: add support for disconnected variants#47088johngodley wants to merge 2 commits intotrunkfrom
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 1 file.
Coverage check overridden by
I don't care about code coverage for this PR
|
Adds disconnected variants to the Agents Manager init file. These load minimal versions that insert help icons in:
It also fixes an issue with P2
Fixes #
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/agents-manager-disconnectedcd apps/agents-manageryarn dev --syncP2 (with unified UI enabled and disabled)
?appears in the menuwp-admin (with unified UI disabled)
[AgentsManager] wp-admin-disconnected variant loaded (minimal mode)appearsagents-manager-wp-admin-disconnected.cssandjsloads (small size)?appears in the admin bar as normal, and clicking it opens https://wordpress.com/support/wp-admin (with unified UI enabled)
agents-manager-wp-admin.cssandjsloaded?icon the admin bar, and clicking it opens a dropdown. Clicking items opens the chat UIGutenberg (with unified UI disabled)
[AgentsManager] gutenberg-disconnected variant loaded (minimal mode)appears in the consoleagents-manager-disconnected-gutenberg.cssandjsare loaded and are small?appears in the toolbar and clicking it goes to the support pageGutenberg (with unified UI enabled)
agent-manager-gutenberg.cssandjsare loaded?icon in the editor toolbarCIAB (with unified UI enabled)
.wp-env.override.jsonfile (shown below)wp-env startclass-agents-manager.phpin Jetpack, and shortcutshould_use_unified_experienceto returntrue- this fakes the unified UIagents-manager-ciab-disconnected.cssandjsis not loaded?icon the bottom left corner and confirm a menu appearsCIAB (with unified UI disabled)
.wp-env.override.jsonfile (shown below)wp-env start[AgentsManager] ciab-disconnected variant loaded (minimal mode)agents-manager-ciab-disconnected.cssandjsis loaded?in the bottom left cornerCIAB config:
This basically just maps the Agents Manager Jetpack plugin to your code
{ "port": 11080, "testsPort": 11089, "config": { "WP_MEMORY_LIMIT": "512M" }, "mappings": { "wp-content/plugins/agents-manager": "[PATH TO AGENTS MANAGER IN JETPACK]" } }