fix: use SafeSignal in ipc in order to not call GTK funcs from a thread#4854
Merged
Alexays merged 1 commit intoAlexays:masterfrom Feb 13, 2026
Merged
fix: use SafeSignal in ipc in order to not call GTK funcs from a thread#4854Alexays merged 1 commit intoAlexays:masterfrom
Alexays merged 1 commit intoAlexays:masterfrom
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As analyzed in #4777 (comment), the current logic calls GTK functions in a thread-unsafe way. I think the fix probably is just to switch the client IPC to use
SafeSignalinstead ofsigc::signal.I have tested that this code builds and that swaybar at least starts seemingly correctly on my machine. I have not yet observed it long enough to tell if it really fixes the crashes.
Fixes #4751
Fixes #4777