CI and Example Upgrade to Dojo 1.6.1 and Scarb 2.10.1 #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates project dependencies and CI workflow to use latest Dojo and Scarb versions. Switches from asdf to direct binary installation in CI.
okhaimie-dev
changed the title
Contributor
Author
|
@coxmars I modified somethings. Which I believe makes the CI more maintainable and efficient and also used the latest compatible version of dojo |
okhaimie-dev
commented
Jul 26, 2025
| env: | ||
| DOJO_VERSION: 1.6.1 | ||
| SCARB_VERSION: 2.10.1 | ||
| WORKING_DIRECTORY: ./backend/dojo_examples/combat_game |
Contributor
Author
There was a problem hiding this comment.
In the future y'all just need to change the env variable to upgrade the dojo and scarb version no need to worry about asdf
Contributor
|
Hi @okhaimie-dev can you solve the conflicts please |
coxmars
requested changes
Jul 31, 2025
Contributor
coxmars
left a comment
coxmars
left a comment
There was a problem hiding this comment.
LGTM, just sole the conflicts to merge 🫡
Contributor
Author
|
@coxmars conflict resolved |
Contributor
|
@coxmars check this for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
📝 Summary
This PR upgrades the ci and also project dojo and scarb dependency to
1.6.1and2.10.1respectively.Related Issues
Type of Change
Mark with an
xall the checkboxes that apply (like[x]).🔄 Changes Made
What's Changed
fmt --checkfrom the rest of the job for faster feedback, developers will not have to wait till the end of the first job just to know that their format was wrong.Implementation Details
Right now, you don't need to install asdf before installing dojo, all you need to do is change the environmental variable of Dojo and Scarb and removes the worry of having to also maintain asdf.
Technical Notes
Include any technical details that reviewers should be aware of.
🔧 Tests Results
Describe the tests you performed to verify your changes.
Test Coverage
Evidence
Testing Notes
Include any special testing considerations or edge cases checked.
🔜 Next Steps
Indicate actions or improvements to be taken after this PR, if applicable.