Stop Token#to_s from modifying word attribute#3
Open
mieko wants to merge 2 commits intoAaronH:masterfrom
Open
Conversation
This made debugging the parser quite a pain, and extracting the original word impossible without trickery.
For the sake of avoiding weird bugs in the future, the token tags shouldn't play around with mutable strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote a scanner on top of chronic, using its tagger, and this was pretty strange. Token#to_s is elongating its word attribute every time I display it, making it hard to query tokens if they've been tagged.
First commit fixes this bug and includes a testcase.
Second commit alters similar mutable-to_s cases throughout the Tag hierarchy to avoid this situation in the future.