VODE: bail out of the nonlinear solve if we predict negative mass fractions #1921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it seems to cause more problems then it fixes
Member
Author
|
regression tests with this new option enabled: |
Member
Author
|
Note: #1919 has been merged into this PR |
Member
Author
|
Here's the updated regression tests with the merged disabling of Note: the tests run 2x faster than without this PR. |
Member
Author
|
this is ready for review. |
This was referenced Jan 16, 2026
zhichen3
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also disable
integrator.do_species_clipby default. Clipping the integation state seems to do moreharm than good.