Fix block size handling for cross attention in TPU flash attention#301
Merged
Fix block size handling for cross attention in TPU flash attention#301
Conversation
michelle-yooh
changed the title
eltsai
previously approved these changes
Dec 29, 2025
michelle-yooh
force-pushed
the
yooh/correct-default-block-q-dq
branch
from
6bb59bb to
ea75256
Compare
michelle-yooh
force-pushed
the
yooh/correct-default-block-q-dq
branch
from
ea75256 to
364be35
Compare
entrpn
approved these changes
Dec 30, 2025
Perseus14
pushed a commit
that referenced
this pull request
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets the correct default value for
block_q_dqin_tpu_flash_attention