Skip to content

Conversation

@micaeljtoliveira
Copy link
Member

This is to handle experiments not generated with the manager.

@micaeljtoliveira
Copy link
Member Author

@edoyango Here's another small PR for you to have a look. Thanks!

@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (143332e) to head (fba6dc7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          773       782    +9     
=========================================
+ Hits           773       782    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@edoyango edoyango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

So is it the user's responsibility to know whether the experiment being added is already done?

@micaeljtoliveira
Copy link
Member Author

So is it the user's responsibility to know whether the experiment being added is already done?

Yes, that's the idea. This is for the cases when one already has some runs lying around or when the experiment one wants to run cannot be generated by the manager (e.g., it's not supported yet, or it's too complex).

@micaeljtoliveira micaeljtoliveira merged commit 3798590 into main Dec 18, 2025
8 checks passed
@micaeljtoliveira micaeljtoliveira deleted the add_exp branch December 18, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants