Skip to content

Add __repr__ methods to ProfilingManager and ProfilingExperiment. #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
micaeljtoliveira merged 1 commit into from
Dec 3, 2025
Merged

Add __repr__ methods to ProfilingManager and ProfilingExperiment. #41

micaeljtoliveira merged 1 commit into from
Dec 3, 2025

Conversation

@micaeljtoliveira
Copy link
Member

@micaeljtoliveira micaeljtoliveira commented Dec 1, 2025

No description provided.

@micaeljtoliveira
Copy link
Member Author

micaeljtoliveira commented Dec 1, 2025

@manodeep Here is another small PR.

@codecov
Copy link

codecov bot commented Dec 1, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e0e8b73) to head (aa75dc5).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #41   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          751       769   +18     
=========================================
+ Hits           751       769   +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

manodeep
manodeep reviewed Dec 1, 2025
View reviewed changes
manodeep
manodeep reviewed Dec 1, 2025
View reviewed changes
Copy link
Collaborator

@manodeep manodeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment - otherwise, everything else looks good

@micaeljtoliveira
Copy link
Member Author

micaeljtoliveira commented Dec 1, 2025

@manodeep Thanks for the quick review. In the meantime, I realised I had forgotten about the profiling data in the ProfilingManager __repr__. Would you mind having another look?

@micaeljtoliveira micaeljtoliveira force-pushed the repr branch 2 times, most recently from d5bbc0b to d9ab105 Compare December 2, 2025 05:57
@micaeljtoliveira
Copy link
Member Author

micaeljtoliveira commented Dec 2, 2025

@manodeep Tests are now fixed and this is ready for a second review.

manodeep
manodeep reviewed Dec 3, 2025
View reviewed changes
Copy link
Collaborator

@manodeep manodeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a minor comment about the white-space indentation - looks good otherwise

@manodeep
Copy link
Collaborator

manodeep commented Dec 3, 2025

LGTM!

@micaeljtoliveira micaeljtoliveira merged commit bb88a5c into main Dec 3, 2025
8 checks passed
@micaeljtoliveira micaeljtoliveira deleted the repr branch December 3, 2025 03:11
@micaeljtoliveira micaeljtoliveira mentioned this pull request Dec 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manodeep manodeep manodeep approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@micaeljtoliveira @manodeep