ThreeJS pipeline module: Setting camera aspect on canvas resize#164
Open
positlabs wants to merge 1 commit into8thwall:masterfrom
Open
ThreeJS pipeline module: Setting camera aspect on canvas resize#164positlabs wants to merge 1 commit into8thwall:masterfrom
positlabs wants to merge 1 commit into8thwall:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The threejs camera needs to update the aspect to match the canvas size. Currently, the aspect is only set during initialization, so if the canvas size changes, the scene will look stretched.
In my case, the canvas wasn't sized before
onStartwas called, so it assigned the aspect based on the default canvas size of 150x300.