Conversation
Owner
|
Thank you for the PR! Shouldn't this be a feature flag in https://github.com/64bit/async-openai/blob/main/async-openai/Cargo.toml#L15-L24 to opt in explicitly? May be Since the library is not using the feature flag directly, it doesn't need to be enabled by default. Open to hear why you'd like to enable it by default? |
Author
|
Oh, that sounds reasonable actually. Although in that case maybe tracing itself should also be enabled by a feature? I tried looking for examples in libraries I expected to have something like this, but apparently they don't have a way to enable tracing-log either. I wonder if I'm missing something. Anyway it's your decision of course |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://docs.rs/tracing/latest/tracing/#emitting-log-records.
Would be helpful for use in python extension crates that want to use pyo3-log