build: install openmldb with rpath#3373
Conversation
LD_LIBRARY_PATH is evil, removing. Replace with the - $ORIGIN token for linux - or @rpath for darwin
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3373 +/- ##
=========================================
Coverage 37.32% 37.32%
Complexity 414 414
=========================================
Files 178 178
Lines 10308 10308
Branches 1206 1206
=========================================
Hits 3847 3847
Misses 6220 6220
Partials 241 241 ☔ View full report in Codecov by Sentry. |
|
Doc about udf dir should fix https://openmldb.ai/docs/zh/main/openmldb_sql/udf_develop_guide.html?highlight=udf#id9 And I strongly recommend this pr don't be released before it has enough tests(integration). We should add tests asap |
No worry, I'll add tests in this PR. Original |
Very Good! Original FTR We'll consider 0.8.2 as a stable version about udf and hive, if new version get error, test on 0.8.2 |
- start & stop onebox services with pidfile
|
openmldb-batch test fails on mac:
|
- assert expected exceptions with testng - upgrade testng to 7.5.1 - improve start_onebox.sh
|
TODO:
|
LD_LIBRARY_PATH is evil, removing. Replace with the
$ORIGINtoken for linux@rpathfor darwinOther fixes:
CREATE FUNCTIONin openmldb-jdbc