Adds publish/share/refCount operators and respective tests#6
Open
christophstrasen wants to merge 1 commit into4O4:masterfrom
Open
Adds publish/share/refCount operators and respective tests#6christophstrasen wants to merge 1 commit into4O4:masterfrom
christophstrasen wants to merge 1 commit into4O4:masterfrom
Conversation
Owner
|
Hi, thank you for your contribution 🎉 I will review it in the upcoming days |
Author
|
Appreciated :). And FYI on the main branch I maintain a more "radical" change for compatibibility with more restrictive lua environments but that may be a bridge too far to upstream so I did not make a PR for that. https://github.com/christophstrasen/lua-reactivex/tree/main Cheers |
Owner
|
Oh that's neat! Actually I would be okay with integrating more platform-specific changes as long as we can keep compatibility for different platforms. My own usage was also always outside of Love2D scope, but I always postponed adding more information about it 🙈 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three familiar Rx operators:
I lean on these in LQR to fan out streams without resubscribing upstream. Figured they belong in core so others can use the same patterns. Tests included and wired into the operator suite but I lack the travisCI setup to run them so apologies if something fails.
Mad props to you for the work on lua-reactivex :)