Update apicast schema manifest

[mayorova]

This is to align with the changes proposed in https://github.com/3scale/porta/pull/4069/files#diff-90f30fa09f863d71761b6497bab4b2c299b7b29a5685f84fe7ae42ab792e318a

[tkan145]

This makes me think that APIcast never cares about the schema

[tkan145]

According to #522 and #565 the manifest and schema is mostly used for the UI. And from #646, we only run validation with busted test. So as long as the test passes, I'm happy.

@mayorova with porta changing to json_schemer, do we still validate each policy schema against the manifest?

[mayorova]

@tkan145 I am not very familiar with the code, but from here it seems to me that APIcast only validates the configuration of the policy definition, not the complete JSON.

As for porta, it's strange, because I think the validation only applies to the policies definitions that are created manually via API. And yes, the whole policy definition is validated against the manifest.
For the policies fetched from APIcast, I don't think we run any validations, just render them in the UI.

[tkan145]

@mayorova yes you are right, I think they used to validate the schema against the manifest manually with this docker image https://github.com/3scale-archive/docker-ajv

[tkan145]

Also, if a user has a custom policy and performs upgrade with the old schema, would that cause any problems?

[mayorova]

Also, if a user has a custom policy and performs upgrade with the old schema, would that cause any problems?

I tried to keep backwards compatibility, so that the old policies stored in the database still keep validating correctly. The aproach is ignoring #manifest, see here. There is also a test here

[tkan145]

@mayorova LGTM, but please don't merge it yet, I need to release version 2.16 with the old scheme first.

[tkan145]

@mayorova Sorry for the long delay, we had some issues with luarocks (lua package manager).

Can you rebase on top of master branch? Once CI passes we can merge this one