Enhanced Palette Selection System #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tried to minimise unnecessary changes as much as possible, but please note that most of the code is AI-generated.
This pull request introduces a flexible palette selection system to the Performance application, allowing users to choose between a palette that changes depending on the MIDI channel and a manual palette selection.
The custom palette UI has therefore also been updated. Firstly, all buttons now function as toggles. The action that previously displayed the palette viewer when the custom palette button was pressed has been changed to occur when it is long-pressed.
Regarding the UI colours, as I am not entirely sure about MatrixOS's UI colour rules, I have set them as shown in the following image for now.