Add PHP 8.0 named parameters support#264
Open
BrianHenryIE wants to merge 6 commits into10up:trunkfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for using PHP 8.0 named parameters.
Closes:
No issue opened.
Details
Trying to call a mocked function like:
results in:
This now works:
The changes use the
argsarray's keys as the parameter names in the mocked function.NB: this does not work:
The
Functions::createFunction()has already been called and the function skeleton built andeval()'d, which is where the parameter names must be added.Contributor checklist
Testing
One test added which skips if the PHP version is too low.
Reviewer checklist