Tests: v2 routing, single-vault withdraw, totalAssets view, transfer re-attribution#36
Draft
youngkidwarrior wants to merge 3 commits intoadd_erc4626_v2_tests_routing_transfers_no-loop_withdraws_from
Conversation
…re-attribution - Deposit routes via affiliates(user) and records underlying shares - Withdraw resolves to a single vault and reverts when insufficient - totalAssets sums convertToAssets across wrapper-held positions in tracked vaults - Transfers proportionally re-attribute underlying shares (no external calls) Test plan: - Run: bunx hardhat test test/rewards/SendEarnRewards.erc4626.spec.ts
Why: - Transfers no longer re-attribute underlying shares; we will update flows and asset mappings only on deposit/withdraw/redeem per the corrected docs - Remove per-user active vault tracking used only for re-attribution Test plan: - Compile
- Purpose/scope, definitions, dependencies, state model, invariants, resolution - Triggers, placeholder policy, lifecycle flows with precise steps - Rounding/safety/observability/failure modes/implementation notes/open items Test plan: - Render docs; verify sections and step details
This was referenced Sep 24, 2025
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests: v2 routing, single-vault withdraw, totalAssets view, transfer re-attribution
Test plan:
Revert per-user transfer re-attribution; remove _update override
Why:
asset mappings only on deposit/withdraw/redeem per the corrected docs
Test plan:
Docs: expand CFA v2.1 into professional spec
Test plan: