From d691d2e8b62932bbe5c39267b47427946087dda4 Mon Sep 17 00:00:00 2001 From: Doug Jacob Date: Wed, 12 Feb 2025 08:55:59 -0700 Subject: [PATCH 1/2] Removed exactly one large-ish comment from TrellServer.cs --- Trell/IPC/Server/TrellServer.cs | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/Trell/IPC/Server/TrellServer.cs b/Trell/IPC/Server/TrellServer.cs index 02a7c3e..4390d03 100644 --- a/Trell/IPC/Server/TrellServer.cs +++ b/Trell/IPC/Server/TrellServer.cs @@ -125,28 +125,5 @@ public override Task NotifyWorkerReady(WorkerReady request, ServerCallCon /// public override Task Log(LogRequest request, ServerCallContext context) { throw new NotImplementedException(); - - //if (extensionContainer.Logger is not ITrellLogger logger) { - // return Task.FromResult(MessageConstants.Empty); - //} - - //var trellLogLevel = request.LogLevel switch { - // LogLevel.Error => TrellLogLevel.Error, - // LogLevel.Warning => TrellLogLevel.Warn, - // _ => TrellLogLevel.Info, - //}; - - //if (!executionContextById.TryGetValue(request.ExecutionId, out var ctx)) { - // var metadata = new Metadata { - // { "ExecutionId", request.ExecutionId } - // }; - // throw new RpcException( - // new Status(StatusCode.InvalidArgument, "ExecutionId does not exist"), - // metadata); - //} - - //logger.Log(ctx, trellLogLevel, request.Message); - - //return Task.FromResult(MessageConstants.Empty); } } From 66dfc0dc6f2109c5452d2134fc553fa6caf703b7 Mon Sep 17 00:00:00 2001 From: Doug Jacob Date: Wed, 12 Feb 2025 09:17:46 -0700 Subject: [PATCH 2/2] Removed the entirety of Trell server logging from the .cs file and protobuf --- Trell/IPC/Server/TrellServer.cs | 11 ----------- Trell/Protos/TrellServer.proto | 3 --- 2 files changed, 14 deletions(-) diff --git a/Trell/IPC/Server/TrellServer.cs b/Trell/IPC/Server/TrellServer.cs index 4390d03..a94601d 100644 --- a/Trell/IPC/Server/TrellServer.cs +++ b/Trell/IPC/Server/TrellServer.cs @@ -115,15 +115,4 @@ public override Task NotifyWorkerReady(WorkerReady request, ServerCallCon Serilog.Log.Information("Worker {Id} is ready.", request.WorkerId); return Task.FromResult(MessageConstants.Empty); } - - /// - /// Called from the worker (on a user's behalf) to log. - /// - /// - /// - /// - /// - public override Task Log(LogRequest request, ServerCallContext context) { - throw new NotImplementedException(); - } } diff --git a/Trell/Protos/TrellServer.proto b/Trell/Protos/TrellServer.proto index a6dfea3..3ac450e 100644 --- a/Trell/Protos/TrellServer.proto +++ b/Trell/Protos/TrellServer.proto @@ -31,9 +31,6 @@ service TrellServer { // -------------------- START INTERNAL API ----------------------------- - // Called from the worker (on a user's behalf) to log. - rpc Log(LogRequest) returns (google.protobuf.Empty); - // Called from the worker to let server know it is ready to work. rpc NotifyWorkerReady(WorkerReady) returns (google.protobuf.Empty);