From cdf8861339035041b7e67e317ea2cac758051e9b Mon Sep 17 00:00:00 2001
From: shubhanshum <40490896+shubhanshum@users.noreply.github.com>
Date: Tue, 6 Aug 2019 13:42:06 +0530
Subject: [PATCH] Update SignInTest.java

---
 src/main/java/SignInTest.java | 64 ++++++++++++++++++++++++++++++-----
 1 file changed, 55 insertions(+), 9 deletions(-)

diff --git a/src/main/java/SignInTest.java b/src/main/java/SignInTest.java
index 2c109950..28cf0f62 100644
--- a/src/main/java/SignInTest.java
+++ b/src/main/java/SignInTest.java
@@ -1,32 +1,74 @@
 import com.sun.javafx.PlatformUtil;
+
+
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebDriver;
+import org.openqa.selenium.WebElement;
 import org.openqa.selenium.chrome.ChromeDriver;
+import org.openqa.selenium.support.FindBy;
+import org.openqa.selenium.support.PageFactory;
+import org.openqa.selenium.support.ui.ExpectedConditions;
+import org.openqa.selenium.support.ui.WebDriverWait;
 import org.testng.Assert;
 import org.testng.annotations.Test;
 
 public class SignInTest {
 
-    WebDriver driver = new ChromeDriver();
+    static WebDriver driver = new ChromeDriver();
+    
+    @FindBy(linkText = "Your trips")
+	private WebElement lnk_yourTrips;
+    
+    @FindBy(id = "SignIn")
+	private WebElement btn_signIn;
+    
+    @FindBy(id = "modal_window")
+	private WebElement iframe_signInPopup;
+    
+    @FindBy(id = "signInButton")
+	private WebElement btn_signInOnPopup;
+    
+    @FindBy(id = "errors1")
+	private WebElement str_submissionError;
 
     @Test
-    public void shouldThrowAnErrorIfSignInDetailsAreMissing() {
+    public void shouldThrowAnErrorIfSignInDetailsAreMissing(String childStr) {
 
-        setDriverPath();
+    	childStr="There were errors in your submission";
+    	
+    	setDriverPath();
 
         driver.get("https://www.cleartrip.com/");
-        waitFor(2000);
+        driver.manage().window().maximize();
+        
+        //Initialize page objects
+        PageFactory.initElements(driver, this);
+        
+        //Don't use static waits.Use explicit wait
+        explicitWaitTillElementVisibility(lnk_yourTrips);
 
-        driver.findElement(By.linkText("Your trips")).click();
-        driver.findElement(By.id("SignIn")).click();
+        lnk_yourTrips.click();
+        btn_signIn.click();
 
-        driver.findElement(By.id("signInButton")).click();
+        //switching to frame
+        switchToFrame(iframe_signInPopup);
+        btn_signInOnPopup.click();
 
-        String errors1 = driver.findElement(By.id("errors1")).getText();
-        Assert.assertTrue(errors1.contains("There were errors in your submission"));
+        String errors1 = str_submissionError.getText();
+        //Don't hardcode constants.Taking value from interface
+        verifyChildStringInParentString(errors1, childStr);
         driver.quit();
     }
 
+    static void explicitWaitTillElementVisibility(WebElement element) {
+    	WebDriverWait wait = new WebDriverWait(driver, 10);
+		wait.until(ExpectedConditions.visibilityOf(element));
+    }
+    
+    private void verifyChildStringInParentString(String parentStr,String childStr) {
+    	Assert.assertTrue(parentStr.contains(childStr));
+    }
+
     private void waitFor(int durationInMilliSeconds) {
         try {
             Thread.sleep(durationInMilliSeconds);
@@ -34,6 +76,10 @@ private void waitFor(int durationInMilliSeconds) {
             e.printStackTrace();  //To change body of catch statement use File | Settings | File Templates.
         }
     }
+    
+    private void switchToFrame(WebElement frame) {
+    	driver.switchTo().frame(frame);
+    }
 
     private void setDriverPath() {
         if (PlatformUtil.isMac()) {