fix: already seen/completed test

rakibansary · rakibansary · commit 90dda14316ab · 2022-02-17T02:19:08.000+06:00
diff --git a/web-assets/auth0/dev-tenant/rules/onboardingChecklist.js b/web-assets/auth0/dev-tenant/rules/onboardingChecklist.js
@@ -115,7 +115,7 @@ function (user, context, callback) {
             
                     for (let checklistTrait of onboardingChecklistTrait.data) {
                         if (checklistTrait.onboarding_wizard != null) {
-                            if ( /* checklistTrait.onboarding_wizard.status != null || */ // any valid status indicates user has already seen onboarding wizard and needn't be shown again.
+                            if ( checklistTrait.onboarding_wizard.status !== 'pending_at_user' || // any non pending_at_user status indicates OB was either seen or completed and can be skipped
                                 checklistTrait.onboarding_wizard.skip ||// for certain signup routes skip is set to true, and thus onboarding wizard needn't be shown
                                 checklistTrait.onboarding_wizard.override === 'skip')
                             {

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,7 @@ function (user, context, callback) {`
`115`	`115`
`116`	`116`	`for (let checklistTrait of onboardingChecklistTrait.data) {`
`117`	`117`	`if (checklistTrait.onboarding_wizard != null) {`
`118`		`- if ( /* checklistTrait.onboarding_wizard.status != null \|\| */ // any valid status indicates user has already seen onboarding wizard and needn't be shown again.`
	`118`	`+ if ( checklistTrait.onboarding_wizard.status !== 'pending_at_user' \|\| // any non pending_at_user status indicates OB was either seen or completed and can be skipped`
`119`	`119`	`checklistTrait.onboarding_wizard.skip \|\|// for certain signup routes skip is set to true, and thus onboarding wizard needn't be shown`
`120`	`120`	`checklistTrait.onboarding_wizard.override === 'skip')`
`121`	`121`	`{`