AS#159623706487509, Remove email subscription logic on members app for landing page after activation

-- removed redundant logic as it is now handled by preferences services by listening for user activation event.

Author: vikasrohit

app/skill-picker/skill-picker.controller.js

@@ -32,7 +32,6 @@ import _ from 'lodash'
      * Activates the controller.
      */
     function activate() {
-      addToMailingList()
       initCommunities()
       checkCommunityStatus()
     }
@@ -138,25 +137,6 @@ import _ from 'lodash'
       }
     }
 
-    function addToMailingList() {
-      return UserPreferencesService.getEmailPreferences(userProfile).then(function(subscription) {
-        logger.debug(subscription)
-        if (!subscription) {
-          return UserPreferencesService.saveEmailPreferences(userProfile).then(function(resp) {
-            logger.debug(resp)
-          }).catch(function(err) {
-            // no error to user
-            //TODO some error alert to community admin
-            logger.debug('error in adding user to member list')    
-          })
-        }
-      }).catch(function(err) {
-        // no error to user
-        //TODO some error alert to community admin
-        logger.debug('error in adding user to member list')
-      })
-    }
-
     /**
      * Persists the user's altered information.
      */