Feature Request: recover nvim-ghost buffer

[mikaraunio]

It seems that currently, nvim-ghost buffers are permanently deleted when the browser disconnects.

I'd love to have a way to recover their content, in case of a server error on form submit, browser crash etc.

[subnut]

Okay, two ways come to my mind -

• Add a :GhostTextKeep command. When you run this command in a buffer created by nvim-ghost, the buffer won't get deleted when the browser disconnects.
• Add a configuration variable g:nvim_ghost_keep_buffers which, when set to 1, will cause nvim-ghost to not delete buffers when the browser disconnects.

---

BTW, sorry for the late reply. These last few months were pretty hectic for me.

[mikaraunio]

Thanks, happy to see this move forward. Think I'd prefer way number 2 so wouldn't have to worry about remembering to run :GhostTextKeep.

[subnut]

Note to self (Implementation details)

• Browser calls close
• We check if g:nvim_ghost_keep_buffers == 1
• If no, current code is followed
• If yes
  • Remove buftype (because we set it so that the user doesn't mistakenly save the temporary buffer, but now that the buffer is no longer going to be changed or deleted, the user may want to save it as a file)
  • (anything else...?)

TIPS

• Rename nvim_ghost#helper#...() to nvim_ghost#server#...()
  eg.
  • nvim_ghost#helper#kill_server() to nvim_ghost#server#kill()
  • nvim_ghost#helper#session_closed() to nvim_ghost#server#close_session()
• From binary, call nvim_ghost#helper#buf_del() or something like that, which contains all the vim code that's currently in the binary itself.

[subnut]

Try the keep-buffers branch, and report issues (if any)

[subnut]

@mikaraunio Have you tried the keep-buffers branch?

[mikaraunio]

@subnut Sorry for the delay. I Trying it now and seeing the following:

• Have set vim.g.nvim_ghost_keep_buffers = 1
• Connected to this comment box and entered text
• Reloaded the page, and the buffer disappears from nvim like before.

[subnut]

Personal note (sample log) -

[17:09:52]: Websocket ::1:48760:0:0 connected to /run/user/1000/nvim.27576.0
[17:09:52]: From 48760 got {"title":"Feature Request: recover nvim-ghost buffer · Issue #47 · subnut/nvim-ghost.nvim","url":"github.com","syntax":"","text":"Hi","selections":[{"start":2,"end":2}]}
[17:09:52]: nvim_event  handle=True  ('nvim_buf_changedtick_event', [<Buffer(handle=3)>, 1])
[17:09:52]: nvim_event  handle=True  ('nvim_buf_lines_event', [<Buffer(handle=3)>, 2, 0, 1, ['Hi'], False])
127.0.0.1 - - [19/Apr/2023 17:09:52] "GET /focus?focus=/run/user/1000/nvim.27576.0 HTTP/1.1" 200 -
127.0.0.1 - - [19/Apr/2023 17:09:53] "GET /focus?focus=/run/user/1000/nvim.27576.0 HTTP/1.1" 200 -
[17:09:55]: nvim_event  handle=True  ('nvim_buf_lines_event', [<Buffer(handle=3)>, 3, 0, 1, ['Hi '], False])
[17:09:55]: To 48760 sent {"text": "Hi ", "selections": [{"start": 3, "end": 3}]}
[17:09:55]: nvim_event  handle=True  ('nvim_buf_lines_event', [<Buffer(handle=3)>, 4, 0, 1, ['Hi t'], False])
[17:09:55]: To 48760 sent {"text": "Hi t", "selections": [{"start": 4, "end": 4}]}
[17:09:55]: nvim_event  handle=True  ('nvim_buf_lines_event', [<Buffer(handle=3)>, 5, 0, 1, ['Hi th'], False])
[17:09:55]: To 48760 sent {"text": "Hi th", "selections": [{"start": 5, "end": 5}]}
[17:09:56]: nvim_event  handle=True  ('nvim_buf_lines_event', [<Buffer(handle=3)>, 6, 0, 1, ['Hi the'], False])
[17:09:56]: To 48760 sent {"text": "Hi the", "selections": [{"start": 6, "end": 6}]}
[17:09:56]: nvim_event  handle=True  ('nvim_buf_lines_event', [<Buffer(handle=3)>, 7, 0, 1, ['Hi ther'], False])
[17:09:56]: To 48760 sent {"text": "Hi ther", "selections": [{"start": 7, "end": 7}]}
[17:09:56]: nvim_event  handle=True  ('nvim_buf_lines_event', [<Buffer(handle=3)>, 8, 0, 1, ['Hi there'], False])
[17:09:56]: To 48760 sent {"text": "Hi there", "selections": [{"start": 8, "end": 8}]}
127.0.0.1 - - [19/Apr/2023 17:09:58] "GET /focus?focus=/run/user/1000/nvim.27576.0 HTTP/1.1" 200 -
[17:10:00]: Websocket ::1:48760:0:0 closed by browser
[17:10:00]: nvim_event  handle=True  ('nvim_buf_detach_event', [<Buffer(handle=3)>])
[17:10:00]: Closing websocket ::1:48760:0:0
[17:10:00]: Websocket ::1:48760:0:0 closed by us

Buffer stays (ie. isn't deleted) but the text is gone.

[subnut]

Further investigation needed.

[17:10:00]: Websocket ::1:48760:0:0 closed by browser
[17:10:00]: nvim_event  handle=True  ('nvim_buf_detach_event', [<Buffer(handle=3)>])
[17:10:00]: Closing websocket ::1:48760:0:0
[17:10:00]: Websocket ::1:48760:0:0 closed by us

Probable race condition or what?

[mikaraunio]

Correction to my comment above, confirm I'm seeing the same thing as you: the buffer stays, but the text is gone.