Editions Support

[oldergod]

https://protobuf.dev/editions/overview/

1st step:

• Explicit error saying editions are not supported.

2nd step:

• Allow edition parsing + hold it in elements + print it.
• Allow feature set parsing + hold it in elements + print it.

3rd step:

• Allow code generation based on it in Java/Kotlin. Swift or grpc-server will be left to the respective teams.

[jianchaoxudd]

hey @oldergod ,

is protobuf edtion supported today or any plan to support it?

[oldergod]

Nothing for now. We don't internally need it so this doesn't get prioritised.

[jianchaoxudd]

Thanks for the info @oldergod ,

Our company is looking for supporting proto edition for our services. Do you have any estimated efforts to support this? Do you think you can prioritize at least support the parsing part?

[JakeWharton]

Seems like something that would make for a good contribution.

[oldergod]

I opened a draft a while ago #2998

but was disatisfied with the API and we stopped.

[jianchaoxudd]

I see. if we are open to contribute to it, how much efforts do you think it will be?

[JakeWharton]

I would start with just the parser not even elements and reject anything other than 2 or 3 at that layer. That should be easy, and is probably adaptable from the above draft PR.

Once that lands, we can build out at least the element support.

Then we can start figuring out the questions in the PR which look like they're at the schema level maybe? Or maybe you don't even need that much. But landing the parser and element support should be uncontroversial.

[oldergod]

Actually, that Syntax is used in the runtime and in ProtofileElement#syntax makes it non trivial.

What exactly do you need @jianchaoxudd ?

[JakeWharton]

The elements aren't public API, though, so that could be changed to a sealed class or different enum type before deciding what to do about the runtime API.

[jianchaoxudd]

hey @oldergod ,

We need be able to parse the protobuf edition syntax, and decoding/encoding and generate stubs . But the parsing and decoding/encoding part is higher priority.

Currently we use wire-schema for:

• SchemaLoader to load/parse protobuf files in our file systems
• decoding/encoding by leveraging ProtoAdapter, ProtoReader and ect

[oldergod]

The elements aren't public API

I think they are? Not to the generated code but in wire-schema, yes.

@jianchaoxudd we probably won't have support for editions before long. If editions parsing itself doesn't unblock you, you'll be blocked again right after I believe.

[JakeWharton]

They're in the internal package of wire-schema.

[jianchaoxudd]

we probably won't have support for editions before long. If editions parsing itself doesn't unblock you, you'll be blocked again right after I believe.

Hey @oldergod ,

Is it because of technical concerns or resourcing concerns? We are willing to allocate resources and contribute to it, but we will need an estimation for this to do resource planning.