Skip to content

v2.5.0 finalizeRelease fails silently in matrix jobs (race condition + swallowed API errors) #709

@JacobTweeten

Description

@JacobTweeten

Summary

After upgrading from softprops/action-gh-release@v2.4.2 to v2.5.0, our release pipeline began failing with:

Run softprops/action-gh-release@v2

Found release <release> (with id=123456789)
♻️ Deleting previously uploaded asset <release>.tar.gz...
⬆️ Uploading <release>.tar.gz...
✅ Uploaded <release>.tar.gz
Finalizing release...
retrying... (2 retries remaining)
retrying... (1 retries remaining)
retrying... (0 retries remaining)
❌ Too many retries. Aborting...
Error: Too many retries.

No error message is printed, even though the GitHub API call is failing.

Pinning back to v2.4.2 resolves the issue immediately.

This strongly suggests a regression introduced in v2.5.0, specifically related to the new “draft until all artifacts are uploaded” feature introduced in PR #692 .

Reproduction

  • Release workflow with multiple build jobs (matrix or separate workflows)
  • All jobs upload assets to the same tag
  • action-gh-release@v2.5.0

Behavior

  • The first job to finish successfully finalizes the release
  • After that, every other job fails during the finalize step
  • The action retries three times and then aborts.
    No underlying API error is printed, making the failure difficult to diagnose.

Expected Behavior

  • One of the jobs succeeds in finalizing the release
  • Other jobs skip finalize or succeed harmlessly

Actual Behavior

  • GitHub API likely returns an error
  • The action's finalizeRelease() catch block does not capture or log the error, because it uses catch {} without an error parameter
  • Only the first job succeds, Every other job retries 3× and fails, leaving the workflow broken

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions