From 01e2001c1c6169848ee085b4349cbc4a5414ca36 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Sun, 18 Jan 2026 16:30:26 -0500 Subject: [PATCH 1/6] Made a few changes to the select ci workflow - Added continuie on error - switched browser on "previous" config to chrome - change setup chrome version to latest --- .github/workflows/Select.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/Select.yml b/.github/workflows/Select.yml index dcc02d7f4..8269134f3 100644 --- a/.github/workflows/Select.yml +++ b/.github/workflows/Select.yml @@ -5,6 +5,7 @@ on: workflow_dispatch jobs: test_config: runs-on: ubuntu-latest + continue-on-error: true strategy: matrix: config: @@ -17,7 +18,7 @@ jobs: python-version: 3.12.12 rf-version: 7.3.2 selenium-version: 4.38.0 - browser: firefox + browser: chrome steps: - uses: actions/checkout@v4 @@ -32,7 +33,7 @@ jobs: - name: Setup ${{ matrix.config.browser }} browser uses: browser-actions/setup-chrome@v1 with: - chrome-version: 138 + chrome-version: latest install-dependencies: true install-chromedriver: true id: setup-chrome From 9da83d39298902e4a521ed18e4bae023988d98db Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Sun, 18 Jan 2026 16:55:02 -0500 Subject: [PATCH 2/6] Removed install drivers step .. --- .github/workflows/Select.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/Select.yml b/.github/workflows/Select.yml index 8269134f3..04cc63ecd 100644 --- a/.github/workflows/Select.yml +++ b/.github/workflows/Select.yml @@ -62,12 +62,6 @@ jobs: - name: Install RF ${{ matrix.config.rf-version }} run: | pip install -U --pre robotframework==${{ matrix.config.rf-version }} - - name: Install drivers via selenium-manager - run: | - SELENIUM_MANAGER_EXE=$(python -c 'from selenium.webdriver.common.selenium_manager import SeleniumManager; sm=SeleniumManager(); print(f"{str(sm._get_binary())}")') - echo "$SELENIUM_MANAGER_EXE" - echo "WEBDRIVERPATH=$($SELENIUM_MANAGER_EXE --browser chrome --debug | awk '/INFO[[:space:]]Driver path:/ {print $NF;exit}')" >> "$GITHUB_ENV" - echo "$WEBDRIVERPATH" - name: Run tests under specified config run: | From 85770182cc72935f309603983c31edb965da5004 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Sun, 18 Jan 2026 17:17:45 -0500 Subject: [PATCH 3/6] Removed install chromedriver flag on setup chrome --- .github/workflows/Select.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/Select.yml b/.github/workflows/Select.yml index 04cc63ecd..071eeb749 100644 --- a/.github/workflows/Select.yml +++ b/.github/workflows/Select.yml @@ -35,7 +35,6 @@ jobs: with: chrome-version: latest install-dependencies: true - install-chromedriver: true id: setup-chrome - run: | echo Installed chromium version: ${{ steps.setup-chrome.outputs.chrome-version }} From d43c0fb42f33150147496e833be19adeb7da2f2b Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Sun, 18 Jan 2026 18:12:29 -0500 Subject: [PATCH 4/6] Yearly update of cookies --- atest/acceptance/keywords/cookies.robot | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/atest/acceptance/keywords/cookies.robot b/atest/acceptance/keywords/cookies.robot index 2349bc68d..29c581ae9 100644 --- a/atest/acceptance/keywords/cookies.robot +++ b/atest/acceptance/keywords/cookies.robot @@ -36,15 +36,21 @@ Add Cookie When Secure Is False Should Be Equal ${cookie.secure} ${False} Add Cookie When Expiry Is Epoch - Add Cookie Cookie1 value1 expiry=1761755100 + # To convert epoch to formatted string + # from time import strftime, localtime + # strftime('%Y-%m-%d %H:%M:%S', localtime(1793247900)) + # To update time each September (as Chrome limits cookies to one year expiry date) use + # import datetime + # print (datetime.datetime.strptime("2027-10-29 12:25:00", "%Y-%m-%d %I:%M:%S").timestamp()) + Add Cookie Cookie1 value1 expiry=1793247900 ${cookie} = Get Cookie Cookie1 ${expiry} = Convert Date ${1761755100} exclude_millis=True Should Be Equal As Strings ${cookie.expiry} ${expiry} Add Cookie When Expiry Is Human Readable Data&Time - Add Cookie Cookie12 value12 expiry=2025-10-29 12:25:00 + Add Cookie Cookie12 value12 expiry=2026-10-29 12:25:00 ${cookie} = Get Cookie Cookie12 - Should Be Equal As Strings ${cookie.expiry} 2025-10-29 12:25:00 + Should Be Equal As Strings ${cookie.expiry} 2026-10-29 12:25:00 Delete Cookie [Tags] Known Issue Safari @@ -122,7 +128,7 @@ Test Get Cookie Keyword Logging Add Cookies # To update time each September (as Chrome limits cookies to one year expiry date) use # import datetime - # print (datetime.datetime.strptime("2025-09-01 12:25:00", "%Y-%m-%d %I:%M:%S").timestamp()) + # print (datetime.datetime.strptime("2027-09-01 12:25:00", "%Y-%m-%d %I:%M:%S").timestamp()) Delete All Cookies Add Cookie test seleniumlibrary ${now} = Get Current Date @@ -130,4 +136,4 @@ Add Cookies ${tomorrow_thistime_datetime} = Convert Date ${tomorrow_thistime} datetime Set Suite Variable ${tomorrow_thistime_datetime} Add Cookie another value expiry=${tomorrow_thistime} - Add Cookie far_future timemachine expiry=1756700700 # 2025-09-01 12:25:00 + Add Cookie far_future timemachine expiry=1788236700 # 2026-09-01 12:25:00 From 36b553a03201c42f695a5be04cbc45dbbe61d5e7 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Sun, 18 Jan 2026 19:01:57 -0500 Subject: [PATCH 5/6] Update couple more cookie tests for the new year --- atest/acceptance/keywords/cookies.robot | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/atest/acceptance/keywords/cookies.robot b/atest/acceptance/keywords/cookies.robot index 29c581ae9..04b355e6a 100644 --- a/atest/acceptance/keywords/cookies.robot +++ b/atest/acceptance/keywords/cookies.robot @@ -44,7 +44,7 @@ Add Cookie When Expiry Is Epoch # print (datetime.datetime.strptime("2027-10-29 12:25:00", "%Y-%m-%d %I:%M:%S").timestamp()) Add Cookie Cookie1 value1 expiry=1793247900 ${cookie} = Get Cookie Cookie1 - ${expiry} = Convert Date ${1761755100} exclude_millis=True + ${expiry} = Convert Date ${1793247900} exclude_millis=True Should Be Equal As Strings ${cookie.expiry} ${expiry} Add Cookie When Expiry Is Human Readable Data&Time @@ -120,7 +120,7 @@ Test Get Cookie Keyword Logging ... domain=localhost ... secure=False ... httpOnly=False - ... expiry=2025-09-01 *:25:00 + ... expiry=2026-09-01 *:25:00 ... extra={'sameSite': 'Lax'} ${cookie} = Get Cookie far_future From de6932f0a27b262dba7bc2bca23910e7d63cfaf0 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Sun, 18 Jan 2026 19:31:53 -0500 Subject: [PATCH 6/6] Update GitHub Action Workflows - Switched over to select.yml for pull request and pushes - Renamed the select workflow - Added an older rf version configuration to the test matrix --- .github/workflows/CI.yml | 2 +- .github/workflows/Select.yml | 9 +++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 1ba18d3db..3a44bbd07 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -1,6 +1,6 @@ name: SeleniumLibrary CI -on: [push, pull_request] +on: workflow_dispatch jobs: build: diff --git a/.github/workflows/Select.yml b/.github/workflows/Select.yml index 071eeb749..dcb89c7e4 100644 --- a/.github/workflows/Select.yml +++ b/.github/workflows/Select.yml @@ -1,6 +1,6 @@ -name: Select Configurations +name: Selected Test Configuration Matrix -on: workflow_dispatch +on: [push, pull_request] jobs: test_config: @@ -19,6 +19,11 @@ jobs: rf-version: 7.3.2 selenium-version: 4.38.0 browser: chrome + - description: older_rf_version + python-version: 3.11.14 + rf-version: 6.1.1 + selenium-version: 4.37.0 + browser: chrome steps: - uses: actions/checkout@v4