Skip to content

[Bug]: Mapbox.MapboxV10 is always true #4131

@g4rb4g3

Description

@g4rb4g3

Mapbox Implementation

Mapbox

Mapbox Version

11.16.6

React Native Version

0.79.6

React Native Architecture

Old Architecture (Paper/bridge)

Platform

iOS

@rnmapbox/maps version

10.2.7

Standalone component to reproduce

import React from 'react';
import {
  MapView,
  ShapeSource,
  LineLayer,
  Camera,
} from '@rnmapbox/maps';

const aLine = {
  type: 'LineString',
  coordinates: [
    [-74.00597, 40.71427],
    [-74.00697, 40.71527],
  ],
};

class BugReportExample extends React.Component {
  render() {
    return (
      <MapView style={{flex: 1}}>
{/* checking for Mapbox.MapboxV10 is always true, no matter what mapbox version is used actually */}
      </MapView>
    );
  }
}

Observed behavior and steps to reproduce

Mapbox.MapboxV10 is always true, no matter what mapbox version is set

Expected behavior

Mapbox.MapboxV10 should reflect if the mapbox version is 10 or be removed... 😬

Notes / preliminary analysis

I don't know the actual intention of this constant, I just found it while digging around in MarkerView.tsx
Also I think MarkerView.tsx should not check for this and always return a RNMBXMarkerView since the PointAnnotation it uses when not having v10 is broken with new architecture as it can render only a single child on iOS.

Additional links and references

"MapboxV10":true,

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug 🪲Something isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions