Certain angle and epsilon combinations result in errors

[HaoTy]

Certain angle and epsilon combinations result in ZeroDivisionError in mpmath (e.g., theta=4.862909272689599 and epsilon=1e-8) or TypeError: '<' not supported between instances of 'mpc' and 'int' in pygridsynth (e.g., theta=1.42778299794038 and epsilon=1e-8).

Synthesizing random angles at 1e-8 can generate more examples:

from pygridsynth import gridsynth_gates
import numpy as np

eps = 1e-8
num_angles = 100
angles = np.random.default_rng(42).uniform(0, 2 * np.pi, size=num_angles)
for angle in angles:
    try:
        gridsynth_gates(angle, eps)
    except (ZeroDivisionError, TypeError) as e:
        print(eps, angle)

[jlapeyre]

You need to use mpmath.mp.dps and mpmath.mpf.
(See also #5)

The following helps make it a bit more clear:

import mpmath
from mpmath import mpf
from pygridsynth.gridsynth import gridsynth_gates

#  TypeError: '<' not supported between instances of 'mpc' and 'int'
def runA():
    theta = 1.42778299794038
    epsilon = 1e-8
    gates = gridsynth_gates(theta=theta, epsilon=epsilon)
    print(gates)

#  TypeError: '<' not supported between instances of 'mpc' and 'int'
def runB():
    theta = 1.42778299794038
    epsilon = mpf('1e-8')
    gates = gridsynth_gates(theta=theta, epsilon=epsilon)
    print(gates)

# Runs for a long, long time without returning
def runC():
    mpmath.mp.dps = 128 # number of decimal digits
    theta = 1.42778299794038
    epsilon = 1e-8
    gates = gridsynth_gates(theta=theta, epsilon=epsilon)
    print(gates)

# OK
def runD():
    mpmath.mp.dps = 128 # number of decimal digits
    theta = 1.42778299794038
    epsilon = mpf('1e-8')
    gates = gridsynth_gates(theta=theta, epsilon=epsilon)
    print(gates)

And the following script runs without catching any divide by zero error:

from pygridsynth import gridsynth_gates
import numpy as np
import mpmath
mpmath.mp.dps = 128 # number of decimal digits
eps = mpmath.mpf('1e-8')
num_angles = 100
angles = np.random.default_rng(42).uniform(0, 2 * np.pi, size=num_angles)
for angle in angles:
    try:
        gridsynth_gates(angle, eps)
    except (ZeroDivisionError, TypeError) as e:
        print(eps, angle)

[HaoTy]

You need to use mpmath.mp.dps and mpmath.mpf. (See also #5)

Thanks for debugging this and making a pull request!

[HirokiHamaguchi]

close #5