From b2dc816277fe05c5ff9a036ed1708983fb4c77b3 Mon Sep 17 00:00:00 2001 From: abose Date: Wed, 7 Jan 2026 09:18:52 +0530 Subject: [PATCH 1/2] feat: phcode-no-lp-edit class on lp element will disable lp handling for that elelent --- src-node/package-lock.json | 4 ++-- src/LiveDevelopment/BrowserScripts/LiveDevProtocolRemote.js | 3 +++ src/LiveDevelopment/BrowserScripts/RemoteFunctions.js | 3 +++ src/assets/default-project/en/images/play.svg | 4 ++++ src/assets/default-project/en/index.html | 5 +---- tracking-repos.json | 2 +- 6 files changed, 14 insertions(+), 7 deletions(-) create mode 100644 src/assets/default-project/en/images/play.svg diff --git a/src-node/package-lock.json b/src-node/package-lock.json index 8bbf6cbb76..6d6d3779b3 100644 --- a/src-node/package-lock.json +++ b/src-node/package-lock.json @@ -1,12 +1,12 @@ { "name": "@phcode/node-core", - "version": "4.1.2-0", + "version": "5.0.0-0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@phcode/node-core", - "version": "4.1.2-0", + "version": "5.0.0-0", "license": "GNU-AGPL3.0", "dependencies": { "@expo/sudo-prompt": "^9.3.2", diff --git a/src/LiveDevelopment/BrowserScripts/LiveDevProtocolRemote.js b/src/LiveDevelopment/BrowserScripts/LiveDevProtocolRemote.js index 0024fd0e2f..0e266125b0 100644 --- a/src/LiveDevelopment/BrowserScripts/LiveDevProtocolRemote.js +++ b/src/LiveDevelopment/BrowserScripts/LiveDevProtocolRemote.js @@ -492,6 +492,9 @@ // Get the user's current selection const selection = window.getSelection(); var element = event.target; + if(element && element.classList && element.classList.contains("phcode-no-lp-edit")) { + return; + } if (element && element.hasAttribute('data-brackets-id')) { // Check if it's a double-click for direct editing if (event.detail === 2 && !['INPUT', 'TEXTAREA', 'SELECT'].includes(element.tagName)) { diff --git a/src/LiveDevelopment/BrowserScripts/RemoteFunctions.js b/src/LiveDevelopment/BrowserScripts/RemoteFunctions.js index 8803a21501..cd83daf5c5 100644 --- a/src/LiveDevelopment/BrowserScripts/RemoteFunctions.js +++ b/src/LiveDevelopment/BrowserScripts/RemoteFunctions.js @@ -741,6 +741,9 @@ function RemoteFunctions(config = {}) { * @param {Event} event - The click event */ function handleElementClick(element, event) { + if(element && element.classList && element.classList.contains("phcode-no-lp-edit")) { + return; + } if (!LivePreviewView.isElementInspectable(element)) { dismissUIAndCleanupState(); return; diff --git a/src/assets/default-project/en/images/play.svg b/src/assets/default-project/en/images/play.svg new file mode 100644 index 0000000000..7f52186670 --- /dev/null +++ b/src/assets/default-project/en/images/play.svg @@ -0,0 +1,4 @@ + + + + diff --git a/src/assets/default-project/en/index.html b/src/assets/default-project/en/index.html index 944eaf373c..1d7c496bc0 100644 --- a/src/assets/default-project/en/index.html +++ b/src/assets/default-project/en/index.html @@ -26,10 +26,7 @@

Phoenix Code

title="Phoenix Code on YouTube" style="max-width: 320px" /> - - - - + play cloud diff --git a/tracking-repos.json b/tracking-repos.json index df38569d54..1e46438450 100644 --- a/tracking-repos.json +++ b/tracking-repos.json @@ -1,5 +1,5 @@ { "phoenixPro": { - "commitID": "cd0d914edab122e76730b6d113663449ab0a473c" + "commitID": "8446ce6fa5071ed11cfba4c353a43abe732e55f1" } } From 5d7bb5227e1d2508996c72a9b1235af70849800c Mon Sep 17 00:00:00 2001 From: abose Date: Wed, 7 Jan 2026 09:36:59 +0530 Subject: [PATCH 2/2] chore: no hover boxes for phcode-no-lp-edit class and parent check too --- src/LiveDevelopment/BrowserScripts/LiveDevProtocolRemote.js | 2 +- src/LiveDevelopment/BrowserScripts/RemoteFunctions.js | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/LiveDevelopment/BrowserScripts/LiveDevProtocolRemote.js b/src/LiveDevelopment/BrowserScripts/LiveDevProtocolRemote.js index 0e266125b0..7b62687b26 100644 --- a/src/LiveDevelopment/BrowserScripts/LiveDevProtocolRemote.js +++ b/src/LiveDevelopment/BrowserScripts/LiveDevProtocolRemote.js @@ -492,7 +492,7 @@ // Get the user's current selection const selection = window.getSelection(); var element = event.target; - if(element && element.classList && element.classList.contains("phcode-no-lp-edit")) { + if(element && element.closest('.phcode-no-lp-edit')) { return; } if (element && element.hasAttribute('data-brackets-id')) { diff --git a/src/LiveDevelopment/BrowserScripts/RemoteFunctions.js b/src/LiveDevelopment/BrowserScripts/RemoteFunctions.js index cd83daf5c5..7232df402e 100644 --- a/src/LiveDevelopment/BrowserScripts/RemoteFunctions.js +++ b/src/LiveDevelopment/BrowserScripts/RemoteFunctions.js @@ -601,6 +601,9 @@ function RemoteFunctions(config = {}) { if(!LivePreviewView.isElementInspectable(element) || element.nodeType !== Node.ELEMENT_NODE) { return false; } + if(element && element.closest('.phcode-no-lp-edit')) { + return false; + } // if _hoverHighlight is uninitialized, initialize it if (!_hoverHighlight && shouldShowHighlightOnHover()) { @@ -741,7 +744,7 @@ function RemoteFunctions(config = {}) { * @param {Event} event - The click event */ function handleElementClick(element, event) { - if(element && element.classList && element.classList.contains("phcode-no-lp-edit")) { + if(element && element.closest('.phcode-no-lp-edit')) { return; } if (!LivePreviewView.isElementInspectable(element)) {