Fixed bug with ordering of binds in PL/SQL when the bind variable may

potentially exceed the 32767 byte limit but the actual value bound does
not (#146).

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -33,6 +33,9 @@ Thin Mode Changes
 #)  Fixed bug with SQL containing multibyte characters with certain database
     character sets
     (`issue 133 <https://github.com/oracle/python-oracledb/issues/133>`__).
+#)  Fixed bug with ordering of binds in PL/SQL when the bind variable may
+    potentially exceed the 32767 byte limit but the actual value bound does not
+    (`issue 146 <https://github.com/oracle/python-oracledb/issues/146>`__).
 #)  Fixed bug connecting to an IPv6 address with IAM tokens.
 #)  Implementation changes:
 

src/oracledb/impl/thin/messages.pyx

@@ -1061,7 +1061,8 @@ cdef class MessageWithData(Message):
                 for value in var_impl._values[:num_elements]:
                     self._write_bind_params_column(buf, var_impl, value)
             else:
-                if var_impl.buffer_size >= TNS_MIN_LONG_LENGTH:
+                if not self.cursor_impl._statement._is_plsql \
+                        and var_impl.buffer_size >= TNS_MIN_LONG_LENGTH:
                     found_long = True
                     continue
                 self._write_bind_params_column(buf, var_impl,

tests/test_4300_cursor_other.py

@@ -888,5 +888,28 @@ def test_4368_cursor_rowcount_for_queries(self):
         self.cursor.fetchall()
         self.assertEqual(self.cursor.rowcount, max_rows)
 
+    def test_4369_bind_order_for_plsql(self):
+        "4369 - test bind order for PL/SQL"
+        self.cursor.execute("truncate table TestClobs")
+        sql = """
+            insert into TestClobs (IntCol, CLOBCol, ExtraNumCol1)
+            values (:1, :2, :3)"""
+        data = "x" * 9000
+        rows = [
+            (1, data, 5),
+            (2, data, 6)
+        ]
+        self.cursor.execute(sql, rows[0])
+        plsql = f"begin {sql}; end;"
+        self.cursor.execute(plsql, rows[1])
+        self.connection.commit()
+        oracledb.defaults.fetch_lobs = False
+        self.cursor.execute("""
+            select IntCol, CLOBCol, ExtraNumCol1
+            from TestCLOBs
+            order by IntCol""")
+        fetched_rows = self.cursor.fetchall()
+        self.assertEqual(fetched_rows, rows)
+
 if __name__ == "__main__":
     test_env.run_test_cases()