CLLocationManagerDelegate methods must be declared public

[npvisual]

After marking CoreLocationMiddleware as a public final class, the compiler is complaining about the following :

Method 'locationManager(_:didChangeAuthorization:)' must be declared public because it matches a requirement in public protocol 'CLLocationManagerDelegate'

I am of the opinion that those methods should not be made public, because they are supposed to be internal to our middleware.

So we probably need to extract the compliance to CLLocationManagerDelegate to an non-public class and use that class as the delegate.

[npvisual]

Actually, after trying a different approach, this looks like it would be forced more by the following issue :

Operator function '<>' requires that 'NSObject' conform to 'Middleware'

when we use CoreLocationMiddleware in the chain of Middleware.

let appMiddleware = LoggerMiddleware<IdentityMiddleware<AppAction, AppAction, AppState>>
    .default() <> CoreLocationMiddleware()

Bottom line is still the same though : we might have to extract the CLLocationManagerDelegate implementation to a different class, away from CoreLocationMiddleware .