From 299c2f9c870b5ba5abc9491b71dac1757ac48c54 Mon Sep 17 00:00:00 2001 From: Mirko Boehm Date: Mon, 2 Feb 2026 10:22:53 +0100 Subject: [PATCH] Return XML encoder errors instead of ignoring them Fixes #10 --- pkg/junitxml/writer.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/pkg/junitxml/writer.go b/pkg/junitxml/writer.go index 42f337a..ff9a172 100644 --- a/pkg/junitxml/writer.go +++ b/pkg/junitxml/writer.go @@ -7,12 +7,16 @@ import ( ) func (testsuites JUnitTestSuites) Write(w io.Writer) error { - io.WriteString(w, "\n") + if _, err := io.WriteString(w, "\n"); err != nil { + return fmt.Errorf("failed to write XML header: %w", err) + } enc := xml.NewEncoder(w) enc.Indent("", "\t") if err := enc.Encode(testsuites); err != nil { - fmt.Printf("unable to write XML document: %v", err) + return fmt.Errorf("failed to encode XML document: %w", err) + } + if _, err := io.WriteString(w, "\n"); err != nil { + return fmt.Errorf("failed to write XML footer: %w", err) } - io.WriteString(w, "\n") return nil }