CSS class loading unobtrusively in test environment

[dvodvo]

A go-to pratice with Minitest is to gradually iterate over actions repeatedly, often including puts response.body in the test to verify output without necessarily rendering in the browser.

A useful feature would be to have a setting where one signals that CSS classes for Herb to be loaded by the application. It is great to have the herb errors in tests come up, killing the fou/wl in the egg, however scrolling through the CSS is tedious at best.

[marcoroth]

Hey @dvodvo, I'm not sure I'm following 🤔

I'm not sure how Herb relates to Minitest and CSS here?

[dvodvo]

• run a test with puts response.body in it (to dig into expected output -> especially as assert_response.include?(...) fails )
• if herb detects and error it is rendered in the body... with a boatload of CSS inline. This is not useful, even cumbersome.
I would much rather load the CSS through the regular manner so that it is referenced in the header (& out of the way)

[timkaechele]

Note: I think you mean ReactionView here, Herb is really just an ERB aware HTML parser that has some tooling for linting rules, the actual integration with Rails and ActionView happens via ReactionView.

---

So from what I understand the inline CSS is really cumbersome to work with when running tests, would it make sense to then only render views with ReactionView/Herb when the Rails env is development, but not when the Rails env is test?

If so, you can look into the ReactionView configuration documention

This config could address your issue:

# config/initializers/reactionview.rb

ReActionView.configure do |config|
  # Only use ReactionView in development setups
  config.intercept_erb = Rails.env.development?
  config.debug_mode = Rails.env.development?
end

[dvodvo]

Hello,

I stand corrected of bundling the two as a same object.

Actually, the rendering of the error in test mode is added value. It may be verbose, but it is useful.
It is the inline referencing of CSS classes which is cumbersome; I would rather load them the rails way as a stylesheet file referenced in application.css

[marcoroth]

Currently, the debug_mode for the Herb::Engine is not designed for the test environment, as it's mostly markup for visual inspection in the browser dev tools.

The reason why the error pages are using inline styles is so they can still render if you have an error in your layout. I don't think it makes sense that you should be able to include the stylesheets individually, but I guess you could still do that if you really want.