Skip to content

[Issue] [PHPDOC] Fix bad phpdoc Magento\Eav\Model\ResourceModel\Entity\Attribute\Collection #40354

@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #39155: [PHPDOC] Fix bad phpdoc Magento\Eav\Model\ResourceModel\Entity\Attribute\Collection


Description (*)

This PR fix the bad phpdoc for \Magento\Eav\Model\ResourceModel\Entity\Attribute\Collection.

  • joinLeft:
    • The first argument can be string or array<string, array>
    • The 3th argument can be string or array<string>

Here is an example where the type array is used :

$attributeCollection->joinLeft(
['eav_entity_attribute' => $attributeCollection->getTable('eav_entity_attribute')],
'main_table.attribute_id = eav_entity_attribute.attribute_id',
[]
);

For example, with PHPSTAN is very complicated to setup the project with level 5 or higher :(

Capture d’écran du 2024-09-11 09-42-35

Related Pull Requests

None

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

Setup PHPSTAN with level 5 or higher and run check.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area: FrameworkComponent: Framework/DBUSE ONLY for FRAMEWORK RELATED BUG!Issue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P3May be fixed according to the position in the backlog.Reported on 2.4.xIndicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch

    Type

    No type

    Projects

    Status

    Ready for Development

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions