-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Open
Labels
Area: FrameworkComponent: Framework/DBUSE ONLY for FRAMEWORK RELATED BUG!USE ONLY for FRAMEWORK RELATED BUG!Issue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P3May be fixed according to the position in the backlog.May be fixed according to the position in the backlog.Reported on 2.4.xIndicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branch
Description
This issue is automatically created based on existing pull request: #39155: [PHPDOC] Fix bad phpdoc Magento\Eav\Model\ResourceModel\Entity\Attribute\Collection
Description (*)
This PR fix the bad phpdoc for \Magento\Eav\Model\ResourceModel\Entity\Attribute\Collection.
joinLeft:- The first argument can be
stringorarray<string, array> - The 3th argument can be
stringorarray<string>
- The first argument can be
Here is an example where the type array is used :
magento2/app/code/Magento/Eav/Model/AttributeRepository.php
Lines 114 to 118 in d06337a
| $attributeCollection->joinLeft( | |
| ['eav_entity_attribute' => $attributeCollection->getTable('eav_entity_attribute')], | |
| 'main_table.attribute_id = eav_entity_attribute.attribute_id', | |
| [] | |
| ); |
For example, with PHPSTAN is very complicated to setup the project with level 5 or higher :(
Related Pull Requests
None
Fixed Issues (if relevant)
None
Manual testing scenarios (*)
Setup PHPSTAN with level 5 or higher and run check.
Questions or comments
Contribution checklist (*)
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- All new or changed code is covered with unit/integration tests (if applicable)
- README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- All automated tests passed successfully (all builds are green)
Metadata
Metadata
Assignees
Labels
Area: FrameworkComponent: Framework/DBUSE ONLY for FRAMEWORK RELATED BUG!USE ONLY for FRAMEWORK RELATED BUG!Issue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P3May be fixed according to the position in the backlog.May be fixed according to the position in the backlog.Reported on 2.4.xIndicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branch
Type
Projects
Status
Ready for Development
