add a enumsafety linter

[onokonem]

Welcome

• Yes, I've searched similar issues on GitHub and didn't find any.
• I agree to follow this project's Code of Conduct

How did you install golangci-lint?

go install

Your feature request related to a problem? Please describe

not a problem, just new linter

Describe the solution you'd like

It would be great if my new linter could be added to the golangci-lint.

It is golang.org/x/tools/go/analysis based so it must be straightforward.

Thank you.

PS
You have added another linter of mine a long time ago: err113

Describe alternatives you've considered

there are no alternatives as far as I can find out with google

Additional context

No response

Supporter

• I am a sponsor through GitHub or OpenCollective

[boring-cyborg]

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

[ldez]

I through it was a linter's idea as there is no link to a linter, and no repository inside the user account.

But the linter is inside an organization https://github.com/Djarvur/go-enumsafety

It feels very similar to #6212

[ldez]

1. It is AI generated, I have no confidence in the maintainability.
2. The analyzer is inside an internal package, so it cannot be imported.
3. Use init
4. The rules about comments are "inventing" a convention.
5. The approach will lead to false positives
6. It suggests micro optimizations as "memory efficient" which is not really.

So we will decline.

[onokonem]

Hi @ldez ,

1. yes it is AI-generated, but I've checked all the tests and the are relevant. I've checked all the code also, and it is ok from my point of view. What do you want me to do, rewrite it by hand? :)
2. yeah, my bad, I'll fix it tomorrow
3. will fix also
4. yes that's true, and there are params to disable them. What would you suggest, make these rules disabled by default?
5. please be more specific.
6. What is your suggestion for the quasy-enum base type?

I'm really open for the ideas and suggestions, so let's discuss this.

My linter is solving "golang does not have a proper enum type" problem, so I would like to see in in the golangci-lint