Skip to content
This repository was archived by the owner on Jul 24, 2025. It is now read-only.
This repository was archived by the owner on Jul 24, 2025. It is now read-only.

Git-aware notification does not work if branch not defined #20

@ilkka

Description

@ilkka

I've purposefully not set :branch in my Capfile, to be able to deploy the currently checked out branch. This causes notifications to fail, however, wth

    triggering after callbacks for `deploy'
  * 2013-10-15 10:47:00 executing `flowdock:notify_deploy_finished'
    triggering before callbacks for `flowdock:notify_deploy_finished'
  * 2013-10-15 10:47:00 executing `flowdock:set_flowdock_api'
Flowdock: error in sending notification to your flow: undefined local variable or method `branch' for #<Capistrano::Configuration::Namespaces::Namespace:0x007fcff24d2168>
  * 2013-10-15 10:47:00 executing `flowdock:save_deployed_branch'
  * executing "echo 'HEAD' > /path/to/myapp/current/BRANCH"

I think the process should be smart enough to git rev-parse --abbrev-ref HEAD if the branch has not been given.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions