From e7c94b6d34ad6c46a681d95b3e20351f6918718e Mon Sep 17 00:00:00 2001 From: Benjamin Milde Date: Fri, 24 Oct 2025 10:59:26 +0200 Subject: [PATCH] Clean 1.19 warnings --- lib/explorer/data_frame.ex | 14 ++++++++++---- mix.exs | 5 ++++- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/lib/explorer/data_frame.ex b/lib/explorer/data_frame.ex index 7b84d9839..53c17cba8 100644 --- a/lib/explorer/data_frame.ex +++ b/lib/explorer/data_frame.ex @@ -545,10 +545,16 @@ defmodule Explorer.DataFrame do opts :: Keyword.t() ) :: DataFrame.t() - def from_query!(conn, query, params, opts \\ []) do - case from_query(conn, query, params, opts) do - {:ok, df} -> df - {:error, error} -> raise error + if Code.ensure_loaded?(Adbc) do + def from_query!(conn, query, params, opts \\ []) do + case from_query(conn, query, params, opts) do + {:ok, df} -> df + {:error, error} -> raise error + end + end + else + def from_query!(_conn, _query, _params, _opts) do + raise "you must install :adbc as a dependency in order to use from_query!/3" end end diff --git a/mix.exs b/mix.exs index 843a76cc1..b62d262b7 100644 --- a/mix.exs +++ b/mix.exs @@ -18,7 +18,6 @@ defmodule Explorer.MixProject do package: package(), deps: deps(), docs: docs(), - preferred_cli_env: [ci: :test, "localstack.setup": :test], aliases: [ "rust.lint": ["cmd cargo clippy --manifest-path=native/explorer/Cargo.toml -- -Dwarnings"], "rust.fmt": ["cmd cargo fmt --manifest-path=native/explorer/Cargo.toml --all"], @@ -36,6 +35,10 @@ defmodule Explorer.MixProject do ] end + def cli do + [preferred_cli_env: [ci: :test, "localstack.setup": :test]] + end + defp elixirc_paths(:test), do: ~w(lib test/support) defp elixirc_paths(_), do: ~w(lib)