Skip to content

Possible bug in in _has_root_cert #52

@dpc

Description

@dpc

I added some debug prints:

    def _has_root_cert(self):
        if sys.platform == "darwin":
            name = self.ca_cert_file_path
        else:
            name = "{server} Root CA".format(server=self.server)
        print("Vaild cert? ")
        print(self.check_valid_cert(name, usage="CT,T,T", is_root=True))
        if self.check_valid_cert(name, usage="CT,T,T", is_root=True):
            print("Yes? True.")
            return True
        print("No? False.")
        return False

result:

> mtls -s some-prod certificate create
Retrieving CRL from server...
Writing CRL to /home/dpc/.config/mtls/some-prod/crl.pem
Vaild cert? 
(False, False, False)
Yes? True.
Decrypting User Key...
Generating CSR for bitgo-prod
Signing CSR for verification on server...
CSR Public key does not match previous user key

AFAICT a tuple of three False values becomes True, which is :sus:.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions