From cfc79313d3440aa4d32f83e8b5017e0003a3723b Mon Sep 17 00:00:00 2001 From: Mike Johanson Date: Wed, 11 Feb 2026 12:07:33 -0700 Subject: [PATCH] build(docs): failing to generate api spec should not be fatal and should use configured log level --- cmd/app/main.go | 18 +++++++++--------- cmd/app/main_test.go | 6 ++---- 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/cmd/app/main.go b/cmd/app/main.go index 8d09b232..c7a6e272 100644 --- a/cmd/app/main.go +++ b/cmd/app/main.go @@ -90,9 +90,7 @@ func handleDebugMode(cfg *config.Config) { if os.Getenv("GIN_MODE") != "debug" { go launchBrowser(cfg) } else { - if err := handleOpenAPIGeneration(); err != nil { - log.Fatalf("Failed to generate OpenAPI spec: %s", err) - } + handleOpenAPIGeneration(cfg) } } @@ -107,8 +105,8 @@ func launchBrowser(cfg *config.Config) { } } -func handleOpenAPIGeneration() error { - l := logger.New("info") +func handleOpenAPIGeneration(cfg *config.Config) { + l := logger.New(cfg.Level) usecases := usecase.Usecases{} // Create OpenAPI generator @@ -117,17 +115,19 @@ func handleOpenAPIGeneration() error { // Generate specification spec, err := generator.GenerateSpec() if err != nil { - return err + l.Warn("Failed to generate OpenAPI spec: %s", err) + + return } // Save to file if err := generator.SaveSpec(spec, "doc/openapi.json"); err != nil { - return err + l.Warn("Failed to save OpenAPI spec: %s", err) + + return } log.Println("OpenAPI specification generated at doc/openapi.json") - - return nil } func handleSecretsConfig(cfg *config.Config) (security.Storager, error) { diff --git a/cmd/app/main_test.go b/cmd/app/main_test.go index ce75169d..e675deaa 100644 --- a/cmd/app/main_test.go +++ b/cmd/app/main_test.go @@ -126,8 +126,7 @@ func TestHandleOpenAPIGeneration_Success(t *testing.T) { mockGen.On("GenerateSpec").Return(expectedSpec, nil) mockGen.On("SaveSpec", expectedSpec, "doc/openapi.json").Return(nil) - err := handleOpenAPIGeneration() - assert.NoError(t, err) + handleOpenAPIGeneration(&config.Config{Log: config.Log{Level: "info"}}) mockGen.AssertExpectations(t) } @@ -145,8 +144,7 @@ func TestHandleOpenAPIGeneration_GenerateFails(t *testing.T) { mockGen.On("GenerateSpec").Return([]byte(nil), assert.AnError) - err := handleOpenAPIGeneration() - assert.Error(t, err) + handleOpenAPIGeneration(&config.Config{Log: config.Log{Level: "info"}}) mockGen.AssertExpectations(t) }