From e18e8b8e4b26df10856979ce7165798478a81793 Mon Sep 17 00:00:00 2001 From: Kishore K G Date: Tue, 30 Dec 2025 05:31:55 +0000 Subject: [PATCH 1/4] Update Ruler frontend_address comments to mention Store Gateway Signed-off-by: Kishore K G --- docs/configuration/config-file-reference.md | 2 +- pkg/ruler/ruler.go | 2 +- schemas/cortex-config-schema.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/configuration/config-file-reference.md b/docs/configuration/config-file-reference.md index 260f9a40a69..5231f18a667 100644 --- a/docs/configuration/config-file-reference.md +++ b/docs/configuration/config-file-reference.md @@ -5147,7 +5147,7 @@ The `ruler_config` configures the Cortex ruler. ```yaml # [Experimental] GRPC listen address of the Query Frontend, in host:port format. # If set, Ruler queries to Query Frontends via gRPC. If not set, ruler queries -# to Ingesters directly. +# to Ingesters and Store Gateway directly. # CLI flag: -ruler.frontend-address [frontend_address: | default = ""] diff --git a/pkg/ruler/ruler.go b/pkg/ruler/ruler.go index 7c9cf64ac74..7ca71e72171 100644 --- a/pkg/ruler/ruler.go +++ b/pkg/ruler/ruler.go @@ -231,7 +231,7 @@ func (cfg *Config) RegisterFlags(f *flag.FlagSet) { //lint:ignore faillint Need to pass the global logger like this for warning on deprecated methods flagext.DeprecatedFlag(f, "ruler.alertmanager-use-v2", "This flag is no longer functional. V1 API is deprecated and removed", util_log.Logger) - f.StringVar(&cfg.FrontendAddress, "ruler.frontend-address", "", "[Experimental] GRPC listen address of the Query Frontend, in host:port format. If set, Ruler queries to Query Frontends via gRPC. If not set, ruler queries to Ingesters directly.") + f.StringVar(&cfg.FrontendAddress, "ruler.frontend-address", "", "[Experimental] GRPC listen address of the Query Frontend, in host:port format. If set, Ruler queries to Query Frontends via gRPC. If not set, ruler queries to Ingesters and Store Gateway directly.") f.StringVar(&cfg.QueryResponseFormat, "ruler.query-response-format", queryResponseFormatProtobuf, fmt.Sprintf("[Experimental] Query response format to get query results from Query Frontend when the rule evaluation. It will only take effect when `-ruler.frontend-address` is configured. Supported values: %s", strings.Join(supportedQueryResponseFormats, ","))) cfg.ExternalURL.URL, _ = url.Parse("") // Must be non-nil f.Var(&cfg.ExternalURL, "ruler.external.url", "URL of alerts return path.") diff --git a/schemas/cortex-config-schema.json b/schemas/cortex-config-schema.json index 3cdc6290259..6af870cbf85 100644 --- a/schemas/cortex-config-schema.json +++ b/schemas/cortex-config-schema.json @@ -6587,7 +6587,7 @@ "x-format": "duration" }, "frontend_address": { - "description": "[Experimental] GRPC listen address of the Query Frontend, in host:port format. If set, Ruler queries to Query Frontends via gRPC. If not set, ruler queries to Ingesters directly.", + "description": "[Experimental] GRPC listen address of the Query Frontend, in host:port format. If set, Ruler queries to Query Frontends via gRPC. If not set, ruler queries to Ingesters and Store Gateway directly.", "type": "string", "x-cli-flag": "ruler.frontend-address" }, From 0200276dbd95ea15ea5af65674e44242b7fbf7b7 Mon Sep 17 00:00:00 2001 From: kishorekg1999 Date: Tue, 30 Dec 2025 17:23:04 +0530 Subject: [PATCH 2/4] Update pkg/ruler/ruler.go Co-authored-by: SungJin1212 Signed-off-by: kishorekg1999 --- pkg/ruler/ruler.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/ruler/ruler.go b/pkg/ruler/ruler.go index 7ca71e72171..a965b33f39d 100644 --- a/pkg/ruler/ruler.go +++ b/pkg/ruler/ruler.go @@ -231,7 +231,7 @@ func (cfg *Config) RegisterFlags(f *flag.FlagSet) { //lint:ignore faillint Need to pass the global logger like this for warning on deprecated methods flagext.DeprecatedFlag(f, "ruler.alertmanager-use-v2", "This flag is no longer functional. V1 API is deprecated and removed", util_log.Logger) - f.StringVar(&cfg.FrontendAddress, "ruler.frontend-address", "", "[Experimental] GRPC listen address of the Query Frontend, in host:port format. If set, Ruler queries to Query Frontends via gRPC. If not set, ruler queries to Ingesters and Store Gateway directly.") + f.StringVar(&cfg.FrontendAddress, "ruler.frontend-address", "", "[Experimental] gRPC address of the Query Frontend (host:port). If set, the Ruler send queries to the Query Frontend to utilize splitting and caching, at the cost of additional network hops compared to direct querying to Ingesters and Store Gateway.") f.StringVar(&cfg.QueryResponseFormat, "ruler.query-response-format", queryResponseFormatProtobuf, fmt.Sprintf("[Experimental] Query response format to get query results from Query Frontend when the rule evaluation. It will only take effect when `-ruler.frontend-address` is configured. Supported values: %s", strings.Join(supportedQueryResponseFormats, ","))) cfg.ExternalURL.URL, _ = url.Parse("") // Must be non-nil f.Var(&cfg.ExternalURL, "ruler.external.url", "URL of alerts return path.") From a52983fffc7dec76458dde306259dae1ebc5db80 Mon Sep 17 00:00:00 2001 From: Kishore K G Date: Tue, 30 Dec 2025 13:13:55 +0000 Subject: [PATCH 3/4] Update Ruler frontend_address comments to mention Store Gateway Signed-off-by: Kishore K G --- docs/configuration/config-file-reference.md | 7 ++++--- schemas/cortex-config-schema.json | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/configuration/config-file-reference.md b/docs/configuration/config-file-reference.md index 5231f18a667..f7deb13faae 100644 --- a/docs/configuration/config-file-reference.md +++ b/docs/configuration/config-file-reference.md @@ -5145,9 +5145,10 @@ The `redis_config` configures the Redis backend cache. The `ruler_config` configures the Cortex ruler. ```yaml -# [Experimental] GRPC listen address of the Query Frontend, in host:port format. -# If set, Ruler queries to Query Frontends via gRPC. If not set, ruler queries -# to Ingesters and Store Gateway directly. +# [Experimental] gRPC address of the Query Frontend (host:port). If set, the +# Ruler send queries to the Query Frontend to utilize splitting and caching, at +# the cost of additional network hops compared to direct querying to Ingesters +# and Store Gateway. # CLI flag: -ruler.frontend-address [frontend_address: | default = ""] diff --git a/schemas/cortex-config-schema.json b/schemas/cortex-config-schema.json index 6af870cbf85..228617db42b 100644 --- a/schemas/cortex-config-schema.json +++ b/schemas/cortex-config-schema.json @@ -6587,7 +6587,7 @@ "x-format": "duration" }, "frontend_address": { - "description": "[Experimental] GRPC listen address of the Query Frontend, in host:port format. If set, Ruler queries to Query Frontends via gRPC. If not set, ruler queries to Ingesters and Store Gateway directly.", + "description": "[Experimental] gRPC address of the Query Frontend (host:port). If set, the Ruler send queries to the Query Frontend to utilize splitting and caching, at the cost of additional network hops compared to direct querying to Ingesters and Store Gateway.", "type": "string", "x-cli-flag": "ruler.frontend-address" }, From 09312a6aca5028880773ea6266c0ca28816ffb50 Mon Sep 17 00:00:00 2001 From: Kishore K G Date: Tue, 30 Dec 2025 16:57:09 +0000 Subject: [PATCH 4/4] empty commit Signed-off-by: Kishore K G