Skip to content

Commit 72b3f2c

Browse files
committed
refactor: adjust targets
1 parent 7fa3e53 commit 72b3f2c

File tree

3 files changed

+16
-2
lines changed

3 files changed

+16
-2
lines changed

code-pushup.preset.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,8 @@ export const eslintCoreConfigNx = async (
179179
})
180180
: await eslintPlugin(await eslintConfigFromAllNxProjects(), {
181181
artifacts: {
182-
generateArtifactsCommand: 'npx nx run-many -t lint-formatter',
182+
// We leverage Nx dependsOn to only run all lint targets before we run code-pushup
183+
// generateArtifactsCommand: 'npx nx run-many -t lint-formatter',
183184
artifactsPaths: ['packages/**/.eslint/eslint-report.json'],
184185
},
185186
}),

nx.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,12 @@
179179
}
180180
},
181181
"code-pushup-eslint": {
182+
"dependsOn": [
183+
{
184+
"target": "lint-formatter",
185+
"projects": "self"
186+
}
187+
],
182188
"cache": true,
183189
"inputs": ["code-pushup-inputs", "lint-eslint-inputs"],
184190
"outputs": ["{projectRoot}/.code-pushup/eslint/runner-output.json"],

project.json

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,14 @@
55
"code-pushup-js-packages": {},
66
"code-pushup-lighthouse": {},
77
"code-pushup-coverage": {},
8-
"code-pushup-eslint": {},
8+
"code-pushup-eslint": {
9+
"dependsOn": [
10+
{
11+
"target": "lint-formatter",
12+
"projects": "*"
13+
}
14+
]
15+
},
916
"code-pushup-jsdocs": {},
1017
"code-pushup-typescript": {},
1118
"code-pushup": {

0 commit comments

Comments
 (0)