From f6cc3a2e9c985b83c0485553fc33c4418df3e023 Mon Sep 17 00:00:00 2001 From: Jagnoor Grewal Date: Sat, 24 Feb 2018 18:06:38 -0500 Subject: [PATCH 1/2] fix: split string to arr before sort --- src/chapter1/ch1-q1.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/chapter1/ch1-q1.js b/src/chapter1/ch1-q1.js index 63a2dcc..5fb4cb5 100644 --- a/src/chapter1/ch1-q1.js +++ b/src/chapter1/ch1-q1.js @@ -35,7 +35,7 @@ export function hasUniqueCharactersSet(str) { */ export function hasUniqueCharactersSort(str) { // sort string using quicksort - str.sort(); + str.split('').sort(); for (var i = 1; i < str.length; ++i) { if (str[i] === str[i - 1]) { From caa4d367018b573998766b0257bc247d8cd0bb94 Mon Sep 17 00:00:00 2001 From: Jagnoor Grewal Date: Sat, 24 Feb 2018 18:22:01 -0500 Subject: [PATCH 2/2] fix: ch1-q1 solution --- src/chapter1/ch1-q1.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/chapter1/ch1-q1.js b/src/chapter1/ch1-q1.js index 5fb4cb5..8e91c47 100644 --- a/src/chapter1/ch1-q1.js +++ b/src/chapter1/ch1-q1.js @@ -35,10 +35,10 @@ export function hasUniqueCharactersSet(str) { */ export function hasUniqueCharactersSort(str) { // sort string using quicksort - str.split('').sort(); + var sortStrArr = str.split('').sort(); - for (var i = 1; i < str.length; ++i) { - if (str[i] === str[i - 1]) { + for (var i = 1; i < sortStrArr.length; ++i) { + if (sortStrArr[i] === sortStrArr[i - 1]) { return false; } }