From 73467b65fdd0da16315d1c3f27f9eeb1abf9771f Mon Sep 17 00:00:00 2001 From: jfox-box Date: Wed, 15 Oct 2025 14:10:25 -0700 Subject: [PATCH 1/2] fix: Fix modernization hook for ContentPickerV2 --- src/elements/content-sharing/ContentSharingV2.tsx | 3 ++- .../stories/tests/ContentSharingV2-visual.stories.tsx | 10 ++++++---- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/elements/content-sharing/ContentSharingV2.tsx b/src/elements/content-sharing/ContentSharingV2.tsx index 35086c9291..a607399de9 100644 --- a/src/elements/content-sharing/ContentSharingV2.tsx +++ b/src/elements/content-sharing/ContentSharingV2.tsx @@ -7,6 +7,7 @@ import type { CollaborationRole, Collaborator, Item, SharedLink, User } from '@b import API from '../../api'; import Internationalize from '../common/Internationalize'; import Providers from '../common/Providers'; +import { withBlueprintModernization } from '../common/withBlueprintModernization'; import { fetchAvatars, fetchCollaborators, fetchCurrentUser, fetchItem } from './apis'; import { useSharingService } from './hooks/useSharingService'; import { convertCollabsResponse, convertItemResponse } from './utils'; @@ -177,4 +178,4 @@ function ContentSharingV2({ ); } -export default ContentSharingV2; +export default withBlueprintModernization(ContentSharingV2); diff --git a/src/elements/content-sharing/stories/tests/ContentSharingV2-visual.stories.tsx b/src/elements/content-sharing/stories/tests/ContentSharingV2-visual.stories.tsx index 41f2c7ceb5..b5d7d64a90 100644 --- a/src/elements/content-sharing/stories/tests/ContentSharingV2-visual.stories.tsx +++ b/src/elements/content-sharing/stories/tests/ContentSharingV2-visual.stories.tsx @@ -1,6 +1,8 @@ import * as React from 'react'; import { expect, screen, userEvent, waitFor, within } from 'storybook/test'; +import { Button } from '@box/blueprint-web'; + import { TYPE_FILE } from '../../../../constants'; import { mockAPIWithCollaborators, @@ -9,7 +11,7 @@ import { } from '../../utils/__mocks__/ContentSharingV2Mocks'; import ContentSharingV2 from '../../ContentSharingV2'; -export const withModernization = { +export const Modernization = { args: { api: mockAPIWithoutSharedLink, enableModernizedComponents: true, @@ -31,7 +33,7 @@ export const withSharedLink = { api: mockAPIWithSharedLink, }, play: async context => { - await withModernization.play(context); + await Modernization.play(context); expect(screen.getByLabelText('Shared link URL')).toBeVisible(); expect(screen.getByRole('button', { name: 'Link Settings' })).toBeVisible(); const peopleWithTheLinkButton = screen.getByRole('button', { name: 'People with the link' }); @@ -51,7 +53,7 @@ export const withCollaborators = { api: mockAPIWithCollaborators, }, play: async context => { - await withModernization.play(context); + await Modernization.play(context); await waitFor(async () => { const sharedWithAvatars = screen.getByRole('button', { name: 'Shared with D R D' }); expect(sharedWithAvatars).toBeVisible(); @@ -69,7 +71,7 @@ export default { title: 'Elements/ContentSharingV2/tests/visual-regression-tests', component: ContentSharingV2, args: { - children: , + children: , itemType: TYPE_FILE, itemID: global.FILE_ID, }, From 516e0f463b87866c9ae8475ae470e70681a98154 Mon Sep 17 00:00:00 2001 From: jfox-box Date: Wed, 15 Oct 2025 14:22:16 -0700 Subject: [PATCH 2/2] fix: Align modernization story names --- .../stories/tests/ContentExplorer-visual.stories.js | 2 +- .../stories/tests/ContentPicker-visual.stories.js | 2 +- .../stories/tests/ContentPreview-visual.stories.js | 2 +- .../stories/tests/ContentSharingV2-visual.stories.tsx | 6 +++--- .../stories/tests/ContentSidebar-visual.stories.tsx | 2 +- .../stories/tests/ContentUploader-visual.stories.js | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/elements/content-explorer/stories/tests/ContentExplorer-visual.stories.js b/src/elements/content-explorer/stories/tests/ContentExplorer-visual.stories.js index 0349fdae9e..009db72022 100644 --- a/src/elements/content-explorer/stories/tests/ContentExplorer-visual.stories.js +++ b/src/elements/content-explorer/stories/tests/ContentExplorer-visual.stories.js @@ -28,7 +28,7 @@ export const basic = { }, }; -export const Modernization = { +export const withModernization = { args: { enableModernizedComponents: true, }, diff --git a/src/elements/content-picker/stories/tests/ContentPicker-visual.stories.js b/src/elements/content-picker/stories/tests/ContentPicker-visual.stories.js index 4db49af5b4..798c775fbe 100644 --- a/src/elements/content-picker/stories/tests/ContentPicker-visual.stories.js +++ b/src/elements/content-picker/stories/tests/ContentPicker-visual.stories.js @@ -8,7 +8,7 @@ import { DEFAULT_HOSTNAME_API } from '../../../../constants'; export const basic = {}; -export const Modernization = { +export const withModernization = { args: { enableModernizedComponents: true, }, diff --git a/src/elements/content-preview/stories/tests/ContentPreview-visual.stories.js b/src/elements/content-preview/stories/tests/ContentPreview-visual.stories.js index d694e1a9db..5a47463aca 100644 --- a/src/elements/content-preview/stories/tests/ContentPreview-visual.stories.js +++ b/src/elements/content-preview/stories/tests/ContentPreview-visual.stories.js @@ -30,7 +30,7 @@ export const basic = { }, }; -export const Modernization = { +export const withModernization = { args: { enableModernizedComponents: true, }, diff --git a/src/elements/content-sharing/stories/tests/ContentSharingV2-visual.stories.tsx b/src/elements/content-sharing/stories/tests/ContentSharingV2-visual.stories.tsx index b5d7d64a90..d3f3c9d055 100644 --- a/src/elements/content-sharing/stories/tests/ContentSharingV2-visual.stories.tsx +++ b/src/elements/content-sharing/stories/tests/ContentSharingV2-visual.stories.tsx @@ -11,7 +11,7 @@ import { } from '../../utils/__mocks__/ContentSharingV2Mocks'; import ContentSharingV2 from '../../ContentSharingV2'; -export const Modernization = { +export const withModernization = { args: { api: mockAPIWithoutSharedLink, enableModernizedComponents: true, @@ -33,7 +33,7 @@ export const withSharedLink = { api: mockAPIWithSharedLink, }, play: async context => { - await Modernization.play(context); + await withModernization.play(context); expect(screen.getByLabelText('Shared link URL')).toBeVisible(); expect(screen.getByRole('button', { name: 'Link Settings' })).toBeVisible(); const peopleWithTheLinkButton = screen.getByRole('button', { name: 'People with the link' }); @@ -53,7 +53,7 @@ export const withCollaborators = { api: mockAPIWithCollaborators, }, play: async context => { - await Modernization.play(context); + await withModernization.play(context); await waitFor(async () => { const sharedWithAvatars = screen.getByRole('button', { name: 'Shared with D R D' }); expect(sharedWithAvatars).toBeVisible(); diff --git a/src/elements/content-sidebar/stories/tests/ContentSidebar-visual.stories.tsx b/src/elements/content-sidebar/stories/tests/ContentSidebar-visual.stories.tsx index c572e45ea6..8edd73b9fc 100644 --- a/src/elements/content-sidebar/stories/tests/ContentSidebar-visual.stories.tsx +++ b/src/elements/content-sidebar/stories/tests/ContentSidebar-visual.stories.tsx @@ -23,7 +23,7 @@ export default { }, }; -export const Modernization = { +export const withModernization = { args: { enableModernizedComponents: true, }, diff --git a/src/elements/content-uploader/stories/tests/ContentUploader-visual.stories.js b/src/elements/content-uploader/stories/tests/ContentUploader-visual.stories.js index 0312cba0eb..2867a86bec 100644 --- a/src/elements/content-uploader/stories/tests/ContentUploader-visual.stories.js +++ b/src/elements/content-uploader/stories/tests/ContentUploader-visual.stories.js @@ -23,7 +23,7 @@ export const basic = { }, }; -export const Modernization = { +export const withModernization = { args: { enableModernizedComponents: true, },