From 480de2a4fda690c5a7439ea04f143c16bbc10608 Mon Sep 17 00:00:00 2001 From: Ulrik Sverdrup Date: Sun, 11 May 2025 14:18:22 +0200 Subject: [PATCH 1/5] kernel: Silence unused method warning --- src/kernel.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/kernel.rs b/src/kernel.rs index e82a2cb..66fb910 100644 --- a/src/kernel.rs +++ b/src/kernel.rs @@ -94,6 +94,7 @@ pub(crate) trait GemmKernel { pub(crate) trait Element : Copy + Send + Sync { fn zero() -> Self; fn one() -> Self; + #[cfg_attr(not(test), allow(unused))] fn test_value() -> Self; fn is_zero(&self) -> bool; fn add_assign(&mut self, rhs: Self); From 9ec9522ff04370681908f979f9fc393391d7ec0a Mon Sep 17 00:00:00 2001 From: Ulrik Sverdrup Date: Sun, 11 May 2025 14:18:22 +0200 Subject: [PATCH 2/5] debugmacros: Silence unknown cfg warning --- src/debugmacros.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/debugmacros.rs b/src/debugmacros.rs index 2ce62ff..f973fdb 100644 --- a/src/debugmacros.rs +++ b/src/debugmacros.rs @@ -13,14 +13,14 @@ macro_rules! dprint { } } -#[cfg(feature = "use_debug")] +/* macro_rules! debug { ($e:expr) => { $e; } } +*/ -#[cfg(not(feature = "use_debug"))] macro_rules! debug { ($e:expr) => { } From 55095d1b68a81b552acb4fc62c126894b5d82a56 Mon Sep 17 00:00:00 2001 From: Ulrik Sverdrup Date: Sun, 11 May 2025 14:18:22 +0200 Subject: [PATCH 3/5] example/usegemm: Remove unused method --- examples/usegemm.rs | 3 --- 1 file changed, 3 deletions(-) diff --git a/examples/usegemm.rs b/examples/usegemm.rs index efae1df..e837f1c 100644 --- a/examples/usegemm.rs +++ b/examples/usegemm.rs @@ -21,7 +21,6 @@ use core::fmt::{Display, Debug}; trait Float : Copy + Display + Debug + PartialEq { fn zero() -> Self; - fn one() -> Self; fn from(x: i64) -> Self; fn nan() -> Self; fn is_nan(self) -> bool; @@ -29,7 +28,6 @@ trait Float : Copy + Display + Debug + PartialEq { impl Float for f32 { fn zero() -> Self { 0. } - fn one() -> Self { 1. } fn from(x: i64) -> Self { x as Self } fn nan() -> Self { 0./0. } fn is_nan(self) -> bool { self.is_nan() } @@ -37,7 +35,6 @@ impl Float for f32 { impl Float for f64 { fn zero() -> Self { 0. } - fn one() -> Self { 1. } fn from(x: i64) -> Self { x as Self } fn nan() -> Self { 0./0. } fn is_nan(self) -> bool { self.is_nan() } From 98656ea9989812e14d4d15852445efb574bc7611 Mon Sep 17 00:00:00 2001 From: Ulrik Sverdrup Date: Sun, 11 May 2025 14:18:22 +0200 Subject: [PATCH 4/5] ci: Update cache rule for cross builder --- .github/workflows/ci.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 17efc9c..d440c9a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -138,11 +138,7 @@ jobs: profile: minimal targets: ${{ matrix.target }} - name: Cache cargo plugins - id: cache - uses: actions/cache@v1 - with: - path: ~/.cargo/bin/ - key: ${{ runner.os }}-cargo-plugins + uses: Swatinem/rust-cache@v2 - name: Install cross if: steps.cache.outputs.cache-hit != 'true' run: cargo install cross From a56914dda5c48210a2bd7a2e73a8463ed02bde73 Mon Sep 17 00:00:00 2001 From: Ulrik Sverdrup Date: Sun, 11 May 2025 14:27:26 +0200 Subject: [PATCH 5/5] ci: Pin either=1.13 for MSRV --- .github/workflows/ci.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d440c9a..5b9c9f5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -67,6 +67,10 @@ jobs: - name: Install dependencies if: matrix.install_deps run: ${{ matrix.install_deps }} + - name: Cargo deps locks + if: ${{ matrix.rust == '1.41.1' }} + run: + cargo update -p either --precise 1.13.0 - name: Tests run: | rustc -C target-cpu=native --print cfg