Skip to content

pop #3

@antonmeyer

Description

@antonmeyer

I think, that is not a perfect logic:
if (ranamount >NUM_LEDS) ranamount = NUM_LEDS; // Make sure we're at least utilizing ALL the LED's.
int idex = random16(0, ranamount);

if (idex < NUM_LEDS) {        

I have 180 LEDs. If ranamount is set to 50, I will see only a portion.
From my perspective the idea of the parameter ranamount got a bit lost.

if you want idex < NUM_LEDS, why did´nt you call int idex = random16(0, ranamount -1);
or if the idea of ranamount got lost: int idex = random16(0, NUM_LEDS -1);

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions