From da05bb47fe2ab4aec9dbefdd4cfe70a20fec05e1 Mon Sep 17 00:00:00 2001
From: Jean-Louis Monteiro <jlmonteiro@tomitribe.com>
Date: Wed, 2 Jul 2025 19:26:22 +0200
Subject: [PATCH] feat(#419): filter out static methods from records

Signed-off-by: Jean-Louis Monteiro <jlmonteiro@tomitribe.com>
---
 johnzon-jsonb/pom.xml                         | 24 +++++++++++++++++++
 .../apache/johnzon/jsonb/JsonbRecordTest.java |  2 ++
 pom.xml                                       | 21 ++++++++++------
 3 files changed, 40 insertions(+), 7 deletions(-)

diff --git a/johnzon-jsonb/pom.xml b/johnzon-jsonb/pom.xml
index 55bc88f8..9d035504 100644
--- a/johnzon-jsonb/pom.xml
+++ b/johnzon-jsonb/pom.xml
@@ -248,6 +248,30 @@
           </execution>
         </executions>
       </plugin>
+
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>
+        <version>3.11.0</version>
+        <executions>
+          <execution>
+            <id>default-compile</id>
+            <phase>compile</phase>
+            <goals><goal>compile</goal></goals>
+            <configuration>
+              <release>${maven.compiler.release}</release>
+            </configuration>
+          </execution>
+          <execution>
+            <id>default-testCompile</id>
+            <phase>test-compile</phase>
+            <goals><goal>testCompile</goal></goals>
+            <configuration>
+              <release>17</release>
+            </configuration>
+          </execution>
+        </executions>
+      </plugin>
     </plugins>
   </build>
 </project>
diff --git a/johnzon-jsonb/src/test/java/org/apache/johnzon/jsonb/JsonbRecordTest.java b/johnzon-jsonb/src/test/java/org/apache/johnzon/jsonb/JsonbRecordTest.java
index 86847023..dd496ce2 100644
--- a/johnzon-jsonb/src/test/java/org/apache/johnzon/jsonb/JsonbRecordTest.java
+++ b/johnzon-jsonb/src/test/java/org/apache/johnzon/jsonb/JsonbRecordTest.java
@@ -95,6 +95,7 @@ public void roundTripWithActualJavaRecord() {
         assertEquals(ref, jsonb.fromJson(expectedJson, Person.class));
     }
 
+    //CHECKSTYLE:OFF
     public record Person (String name, LocalDate birthday) {
         public int age() {
             return LocalDate.now().getYear() - birthday.getYear();
@@ -123,4 +124,5 @@ public Person build() {
             }
         }
     }
+    //CHECKSTYLE:ON
 }
diff --git a/pom.xml b/pom.xml
index 69100426..e6a5b90c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -305,6 +305,7 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-checkstyle-plugin</artifactId>
+        <version>3.6.0</version>
         <executions>
           <execution>
             <id>verify-style</id>
@@ -314,8 +315,16 @@
             </goals>
           </execution>
         </executions>
+        <dependencies>
+          <dependency>
+            <groupId>com.puppycrawl.tools</groupId>
+            <artifactId>checkstyle</artifactId>
+            <version>10.21.4</version>
+          </dependency>
+        </dependencies>
         <configuration>
-          <encoding>UTF-8</encoding>
+          <inputEncoding>UTF-8</inputEncoding>
+          <outputEncoding>UTF-8</outputEncoding>
           <excludes>**/module-info*</excludes>
           <consoleOutput>true</consoleOutput>
           <failOnViolation>true</failOnViolation>
@@ -325,14 +334,13 @@
           <logViolationsToConsole>true</logViolationsToConsole>
           <checkstyleRules>
             <module name="Checker">
-              <module name="SuppressionCommentFilter" />
               <module name="FileLength">
                 <property name="max" value="3500" />
                 <property name="fileExtensions" value="java" />
               </module>
               <module name="FileTabCharacter" />
               <module name="TreeWalker">
-                <module name="FileContentsHolder" />
+                <module name="SuppressionCommentFilter"/>
                 <module name="ConstantName">
                   <property name="format" value="^(([A-Z][A-Z0-9]*(_[A-Z0-9]+)*))$" />
                 </module>
@@ -343,6 +351,9 @@
                 <module name="PackageName" />
                 <module name="LocalFinalVariableName" />
                 <module name="ParameterName" />
+                <module name="ParameterNumber">
+                  <property name="max" value="28" />
+                </module>
                 <module name="StaticVariableName" />
                 <module name="TypeName">
                   <property name="format" value="^_?[A-Z][a-zA-Z0-9]*$" />
@@ -353,10 +364,6 @@
                 <module name="IllegalImport" />
                 <module name="RedundantImport" />
                 <module name="UnusedImports" />
-                <module name="LineLength">
-                  <property name="max" value="180" />
-                  <property name="ignorePattern" value="@version|@see" />
-                </module>
                 <module name="MethodLength">
                   <property name="max" value="264" />
                 </module>